-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lane_change): implement terminal lane change feature #9592
Open
mkquda
wants to merge
39
commits into
autowarefoundation:main
Choose a base branch
from
tier4:RT1-8205-implement-terminal-lane-change-feature
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(lane_change): implement terminal lane change feature #9592
mkquda
wants to merge
39
commits into
autowarefoundation:main
from
tier4:RT1-8205-implement-terminal-lane-change-feature
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mohammad alqudah <[email protected]>
…h is found Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
…ent-terminal-lane-change-feature
…e-feature Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: tomoya.kimura <[email protected]>
…e-feature Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Dec 9, 2024
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
mkquda
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Dec 9, 2024
Signed-off-by: mohammad alqudah <[email protected]>
github-actions
bot
added
the
type:documentation
Creating or refining documentation. (auto-assigned)
label
Dec 9, 2024
mkquda
requested review from
satoshi-ota,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
December 11, 2024 02:26
…e-feature Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
mkquda
added
the
run:deploy-docs
Mark for deploy-docs action generation. (used-by-ci)
label
Dec 22, 2024
Signed-off-by: mohammad alqudah <[email protected]>
maxime-clem
approved these changes
Dec 23, 2024
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/README.md
Show resolved
Hide resolved
Signed-off-by: mohammad alqudah <[email protected]>
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/scene.cpp
Outdated
Show resolved
Hide resolved
…on threshold Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
…e-feature Signed-off-by: mohammad alqudah <[email protected]>
...r_path_lane_change_module/include/autoware/behavior_path_lane_change_module/structs/data.hpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/scene.cpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/scene.cpp
Show resolved
Hide resolved
…nge_module/src/scene.cpp Co-authored-by: Zulfaqar Azmi <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
run:deploy-docs
Mark for deploy-docs action generation. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when LC module fails to find a safe lane change path, ego will continue up to the end of current lanes (terminal point) and stop in the middle of the lane. And lane change cannot be performed except by manual override.
To increase the rate of successful LC maneuvers, even in difficult situations, and reduce the need of manual override, it is better to always have a fallback terminal lane change path connecting the end of current lanes to target lanes, in case no valid & safe candidate path is found, the fallback terminal path can be force approved to complete the LC maneuver.
Changes
compute_terminal_lane_change_path
insert_stop_point_on_current_lanes
&calc_dist_to_last_fit_width
enable_terminal_path
to enable/disable the featureThe videos below demonstrate the difference in the behavior:
no_terminal_lc_path.mp4
terminal_lc_path.mp4
Related links
How was this PR tested?
Notes for reviewers
None.
Interface changes
ROS Parameter Changes
Additions and removals
terminal_path.enable
bool
true
terminal_path.disable_near_terminal
bool
true
terminal_path.stop_at_boundary
bool
true
Effects on system behavior
In case of failure to find a valid candidate path until terminal point, if terminal path is computed, it can be force approved to complete LC maneuver successfully.
If using terminal path feature and terminal path is computed, instead of placing stop point in the middle of current lane, stop point will be inserted at the last point along the path where Ego foot print is within current lane boundary. This would result in Ego stopping to the side of the lane, which can help incite other vehicles to give way for Ego.