-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_planning_validator): add collision checking for predicted objects #9143
base: main
Are you sure you want to change the base?
feat(autoware_planning_validator): add collision checking for predicted objects #9143
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
27f5efa
to
a3b3148
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to efficiently check for collisions then you should use an rtree to store and do queries on the ego trajectory footprints.
a3b3148
to
22e2f18
Compare
33ea88e
to
2936bfd
Compare
@satoshi-ota |
…dicted objects Signed-off-by: Kyoichi Sugahara <[email protected]>
…collision checking function Signed-off-by: Kyoichi Sugahara <[email protected]>
…tion and update includes Signed-off-by: kyoichi-sugahara <[email protected]>
…c and data structures Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
…c and data structures Signed-off-by: kyoichi-sugahara <[email protected]>
…ion parameters Signed-off-by: kyoichi-sugahara <[email protected]>
…ory and ego-object distance thresholds Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: Kyoichi Sugahara <[email protected]>
a88eebb
to
cb93cf7
Compare
…ory and ego-object distance thresholds Signed-off-by: Kyoichi Sugahara <[email protected]>
ae89cac
to
6b487bc
Compare
Description
launcher PR should be merged first.
Execute collision detection at each time step based on predicted object movements by checking the planning module output.
Currently, this feature is disabled due to frequent collision detections. We will enable this functionality once we confirm the detection mechanism is sufficiently reliable and beneficial.
Even in the current state, error information is included in the diagnostic topics, allowing for planning evaluation using this data.
How was this PR tested?
run scenario_simulator_v2 and confirmed that detecting collision.
diag_error_trajectory_validation_trajectory_collision_buffered-.2024-11-01-16-52-13.mp4
Looking at the time cross-section, locations where collisions are predicted are visualized with red markers.
Notes for reviewers
None.
Interface changes
add subscriber for
PredictedObjects
ROS Parameter Changes
Additions
trajectory_to_object_distance_threshold
double
30.0
ego_to_object_distance_threshold
double
50.0
time_tolerance_threshold
double
0.1
Effects on system behavior
None.