Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_adapi_rviz_plugin): add legacy state panel #7494

Merged

feat(tier4_adapi_rviz_plugin): add legacy state panel

91e3a1e
Select commit
Loading
Failed to load commit list.
Merged

feat(tier4_adapi_rviz_plugin): add legacy state panel #7494

feat(tier4_adapi_rviz_plugin): add legacy state panel
91e3a1e
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jun 14, 2024 in 38s

CodeScene PR Check

Code Health Quality Gates: OK

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method state_panel.cpp: StatePanel::onMRMState
  • Complex Method state_panel.cpp: StatePanel::onOperationMode

Annotations

Check warning on line 529 in common/tier4_adapi_rviz_plugin/src/state_panel.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

StatePanel::onMRMState has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 354 in common/tier4_adapi_rviz_plugin/src/state_panel.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

StatePanel::onOperationMode has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.