Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pointcloud_preprocessor): add pipeline_latency_ms debug publisher to missed modules #6569

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

brkay54
Copy link
Member

@brkay54 brkay54 commented Mar 7, 2024

Description

In the issue above, we discussed that a more efficient method would be for the nodes themselves to report the delays.

I missed adding this debug publisher to concatenate_pointclouds and time_synchronizer.

Tests performed

Tested with e2e_simulator. Works well.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@brkay54 brkay54 added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) labels Mar 7, 2024
@brkay54 brkay54 self-assigned this Mar 7, 2024
@github-actions github-actions bot removed the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Mar 7, 2024
@brkay54 brkay54 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 7, 2024
@brkay54 brkay54 marked this pull request as ready for review March 7, 2024 13:09
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 14.78%. Comparing base (71c5669) to head (00ddc57).

Files Patch % Lines
...r/src/concatenate_data/concatenate_pointclouds.cpp 0.00% 7 Missing ⚠️
...rc/time_synchronizer/time_synchronizer_nodelet.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6569      +/-   ##
==========================================
- Coverage   14.78%   14.78%   -0.01%     
==========================================
  Files        1917     1917              
  Lines      132253   132266      +13     
  Branches    39297    39297              
==========================================
  Hits        19550    19550              
- Misses      90876    90889      +13     
  Partials    21827    21827              
Flag Coverage Δ *Carryforward flag
differential 5.18% <0.00%> (?)
total 14.78% <ø> (ø) Carriedforward from 71c5669

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miursh miursh requested a review from YoshiRi March 7, 2024 21:59
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I checked with sample-rosbag with tutorial. (Need to merge sample_sensor_kit_PR )

/sensing/lidar/concatenate_pointclouds_debug/debug/sensing/lidar/left/pointcloud/pipeline_latency_ms
/sensing/lidar/concatenate_pointclouds_debug/debug/sensing/lidar/right/pointcloud/pipeline_latency_ms
/sensing/lidar/concatenate_pointclouds_debug/debug/sensing/lidar/top/pointcloud/pipeline_latency_ms
# also found in time_sync pointclouds

@miursh Could you approve as a owner?

@YoshiRi YoshiRi enabled auto-merge (squash) March 8, 2024 18:36
@brkay54
Copy link
Member Author

brkay54 commented Mar 14, 2024

@miursh Sorry to bother you Miura-san. We need an approval from code owners. If you have time, could you check it?

@YoshiRi YoshiRi merged commit 6ee9627 into autowarefoundation:main Mar 14, 2024
23 of 25 checks passed
@brkay54 brkay54 deleted the feat/add-pipeline-latency branch March 14, 2024 11:32
yhisaki pushed a commit to yhisaki/autoware.universe that referenced this pull request Mar 15, 2024
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants