Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(start_planner): keep distance back static objects from start pose #6149
base: main
Are you sure you want to change the base?
feat(start_planner): keep distance back static objects from start pose #6149
Changes from 13 commits
04ef74c
56e82fd
3e919f6
b28ad9d
276f2b3
e27daf8
485364f
098b6fd
16e7104
21c15b7
b73b55c
16a71ce
2b7d88f
29571ff
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 49 in planning/behavior_path_start_planner_module/src/manager.cpp
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
Check notice on line 1 in planning/behavior_path_start_planner_module/src/start_planner_module.cpp
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Lines of Code in a Single File
Check warning on line 1014 in planning/behavior_path_start_planner_module/src/start_planner_module.cpp
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits:
this could be heavy.
I think there are better ways to make it faster, such as extracting the closest object, the closest point, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pseudo code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I will consider improving the efficiency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my current implementation, distance
a
is calculated but distanceb
should be calculated, correct?If so, the method of extracting objects for back distance against back object should be changed. In this sketch, only object [2] should be extracted.
And for caring lateral collision implemented with the following implementetion. objects[0,1,2] should be extracted 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! but it's ok if it takes time to improve because the check target objects may be not so many
no, I think distance
a
should be calculated,I agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about creating polygon along the
start_pose_candidates_path
?autoware.universe/planning/behavior_path_start_planner_module/src/start_planner_module.cpp
Line 885 in 1121f3b
And extracts closest object overlaps with the polygon
a:
objects_collision_check_margins.back()
b:
back_objects_collision_check_margin
It's heavier but checking lateral distance of object pose is not considering the size of the object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
the attention area is along the
start_pose_candidates_path
not just nagative x-coords direction, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which pattern did you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and, better to check just side to ego?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(sorry for my mistake, this pseudo code did not consider footprint)
#6149 (comment)
not just check
object.pose.position
but need to check 4 footprint points by likestd::any