Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin numpy to 2.0.0rc1 #16

Closed
wants to merge 2 commits into from
Closed

Conversation

astrofrog
Copy link
Member

@astrofrog astrofrog commented Apr 5, 2024

Some packages are forcing numpy<2 to be installed, so pinning numpy to 2.0.0rc1 to see what works and what doesn't. Not for merging at this point!

Where the wild things are

@astrofrog
Copy link
Member Author

I'm trying to get reproject to work and have released new wheels but that job is still failing as it requires a new release of astropy-healpix. This is in preparation in astropy/astropy-healpix#214 but running into issues related to copy= which @neutrinoceros is going to investigate.

@pllim
Copy link
Member

pllim commented Apr 5, 2024

asdf-astropy -- I think @braingram is aware of this.

But just in case:

@pllim
Copy link
Member

pllim commented Apr 5, 2024

For completeness, I cross-linked related issues in the original post above. Hope you don't mind. Thanks!

@astrofrog
Copy link
Member Author

That's fantastic, thank you!

@astrofrog
Copy link
Member Author

I've restarted the CI to check where things stand right now.

@astrofrog
Copy link
Member Author

Restarted again

@neutrinoceros
Copy link

Thanks ! I see ccdproc is still not caught up, I'll get back to it !

@neutrinoceros
Copy link

neutrinoceros commented Apr 10, 2024

@astrofrog if you'd like to keep the PR description updated, here's the latest (and last) patch needed for ccdproc astropy/ccdproc#824

Also worth noting that it depends on astroscrappy, which Simon in working on in astropy/astroscrappy#85

@neutrinoceros
Copy link

neutrinoceros commented Apr 10, 2024

Also, I wanted to double check on specreduce and it doesn't just need photutils: the test suite also requires a new release for synphot. @pllim already opened a PR for it as spacetelescope/synphot_refactor#387, and I confirm that it's sufficent to get specreduce's test suite green

@pllim
Copy link
Member

pllim commented Apr 11, 2024

Thanks for the update! I guess I have to release synphot sooner than later...

Update: Released 1.4.0

@pllim
Copy link
Member

pllim commented Apr 11, 2024

Some downstream packages like ginga and acstools need a new photutils release to get their RC testing job to pass. cc @larrybradley

@larrybradley
Copy link
Member

I should have time to do a photutils and regions release tomorrow afternoon.

@pllim
Copy link
Member

pllim commented Apr 15, 2024

I think we're almost there. Should we omit bottleneck to get photutils green or wait it out?

@pllim
Copy link
Member

pllim commented Apr 16, 2024

I merged #17 . Please rebase to ensure sunpy is now green. Thanks!

@astrofrog
Copy link
Member Author

Rebased!

@astrofrog
Copy link
Member Author

@Cadair @pllim - sunpy is still red due to opencv errors.

@nabobalis
Copy link
Contributor

nabobalis commented Apr 16, 2024

sunpy release has not got the numpy fixes yet. We need to get 5.1.3 out.

sunpy-dev still is not skipping the figure tests. I wonder if there is a problem in the pytest config?

@nabobalis
Copy link
Contributor

Actually I think those sunpy dev issues might be on us but I am investigating.

@nabobalis
Copy link
Contributor

nabobalis commented Apr 16, 2024

For sunpy dev I opened: #18 it points to my branch that I hope to merge but it shows sunpy-dev passing under numpy2.0rc now (that last commit needs to go before a merge)

@astrofrog
Copy link
Member Author

Ok so the remaining issues for the CI to turn green are:

  • bottleneck still needs to be released - not a big deal because it's only an optional dependency for astropy and photutils anyway
  • astroscrappy needs to be released for ccdproc - that one is a required dependency but we can do the release ourselves.
  • sunpy needs to be released

None of the issues appear to be related to astropy 6.1 so we should be safe to go ahead and do a release I think.

@pllim
Copy link
Member

pllim commented Apr 29, 2024

Any of these diff actually need to be merged for next time? If not, we can close the PR without merge. Thanks!

@astrofrog
Copy link
Member Author

Looks like bottleneck have an rc out with numpy 2.0 support, so trying to re-run

@neutrinoceros
Copy link

Seems like I missed a spot when I worked on ccdproc, however, the one remaining failure doesn't affect users, and its fixed in astropy/ccdproc#829

@astrofrog
Copy link
Member Author

Everything is green except for ccdproc stable which makes sense since it requires astropy/ccdproc#829 which hasn't been released yet (and is not urgent since doesn't affect users). I think we can close this now!

@astrofrog astrofrog closed this May 13, 2024
@pllim
Copy link
Member

pllim commented May 13, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants