Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: build with numpy 2.0.0rc1 (or newer) #1717

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

neutrinoceros
Copy link
Contributor

This is needed for runtime compatibility with the upcoming numpy 2.0, and I think that it's also sufficient, but maybe I'm missing something ? anyway feel free to push to this branch or to incorporate it some other way.

@larrybradley
Copy link
Member

Many thanks, @neutrinoceros. Why are there merge conflicts?

@neutrinoceros
Copy link
Contributor Author

because I forgot to update my local clone before I branched out. Should be fixed now !

@larrybradley larrybradley merged commit 1f0599b into astropy:main Apr 5, 2024
20 of 21 checks passed
@neutrinoceros neutrinoceros deleted the numpy2_compat branch April 5, 2024 16:56
@pllim
Copy link
Member

pllim commented Apr 5, 2024

Hmm, still see failure over at astropy/astropy-integration-testing#16 so maybe that is something different... https://github.com/astropy/astropy-integration-testing/actions/runs/8568043943/job/23501813211?pr=16

  File "astropy/stats/__init__.py", line 15, in <module>
    from . import (
  File "astropy/stats/sigma_clipping.py", line 16, in <module>
    import bottleneck
  File "bottleneck/__init__.py", line 7, in <module>
    from .move import (move_argmax, move_argmin, move_max, move_mean, move_median,
AttributeError: _ARRAY_API not found

Maybe pydata/bottleneck#445 would fix it?

@larrybradley
Copy link
Member

That looks like an issue in astropy.stats.

There is a small issue I need to fix in photutils (and regions), where I need to add the now-required copy keyword to __array__ methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants