Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: adapt a docstest for numpy 2 (representation of scalars changed) (round 2) #829

Merged
merged 1 commit into from
May 5, 2024

Conversation

neutrinoceros
Copy link
Contributor

Somehow I missed these in #826

Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.62%. Comparing base (349ed6e) to head (2e00b2f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #829   +/-   ##
=======================================
  Coverage   97.62%   97.62%           
=======================================
  Files           9        9           
  Lines        1388     1388           
=======================================
  Hits         1355     1355           
  Misses         33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwcraig
Copy link
Member

mwcraig commented May 5, 2024

Thanks -- should I do another release for this?

@mwcraig mwcraig merged commit 68e90da into astropy:main May 5, 2024
15 checks passed
@neutrinoceros neutrinoceros deleted the numpy2/doctests_2 branch May 5, 2024 15:49
@neutrinoceros
Copy link
Contributor Author

I don't think it's necessary since it doesn't impact users.

@pllim
Copy link
Member

pllim commented May 13, 2024

Based on @astrofrog comment at astropy/astropy-integration-testing#16 (comment) . Maybe should release anyway just to have integration testing green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants