Added pr reviews to stats #1404
Conversation
|
Someone is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1404 +/- ##
==========================================
+ Coverage 97.59% 97.61% +0.02%
==========================================
Files 24 24
Lines 4824 4869 +45
Branches 448 449 +1
==========================================
+ Hits 4708 4753 +45
Misses 115 115
Partials 1 1
☔ View full report in Codecov by Sentry. |
|
Okay maybe we can add this PR review stat. But we need to do it in a way which is non-breaking... TBH from initially my API decision wasn't that great (well i made this project in 15min so what can you expect) By non-breaking, i mean that the review stat should not suddenly pop up on everyone's cards otherwise the card height will increase and will break the layout for many people on the readmes. Maybe we can do a opt-in solution like a param |
|
Yeah I agree. Changed the PR so that "reviews" are hidden by default and visible only when a separate "show" parameter is passed in. Also updated readme about the new feature. |
|
Cant' wait to see the feature merged. |
|
Hey @FayasNoushad , I saw this pr is approved already, what should we do to push this forward then, I'm eager for this feature. |
|
kindly ping @anuraghazra |
|
@kerthcet I fully understand that this is a feature you want. Pinging the repository author, however, does not speed up the PR review process. We already got an alert when you posted #1404 (comment). It only puts more stress on the repository collaborators who maintain this project in their free time. There are currently several other PRs open which have a higher priority (e.g. #1 and #1186). We, therefore, can not give you an ETA for this feature. I would therefore advise you to fork this project, for now, merge #1404 and create your own vercel instance (see https://github.com/anuraghazra/github-readme-stats#deploy-on-your-own-vercel-instance). Hope that helps. Let me know if you have any questions |
|
Sorry guys, my intension here was to check whether this pr is forgotten for approved since last year. |
|
@kerthcet No problem I understand. Feel free to let me know if you run into problems merging this PR on your own fork and deploying it on your own vercel instance. |
|
This looks good, will give final review soon. GOSH I still regret the decision to add the |
|
Revisit this pr again, any progress? |
|
Any progress on this branch? |
rickstaa
force-pushed
the
master
branch
2 times, most recently
from
86aafe8
to
8bc69e7
Compare
github-actions
bot
added
documentation
|
I have merged master branch and refactored the code a little. Please check it and write about your thoughts. If you didn't liked the changed feel free to force push them back. TODO:
|
|
@merged into master. @Marcholio thanks for your contribution! |
* Added pr reviews to stats * Add 'show' query parameter * Fix show test * refactoring * cleanup * refactor: restructure stats-card code --------- Co-authored-by: Markus <[email protected]> Co-authored-by: Alexandr <[email protected]> Co-authored-by: rickstaa <[email protected]>
* Added pr reviews to stats * Add 'show' query parameter * Fix show test * refactoring * cleanup * refactor: restructure stats-card code --------- Co-authored-by: Markus <[email protected]> Co-authored-by: Alexandr <[email protected]> Co-authored-by: rickstaa <[email protected]>
* Added pr reviews to stats * Add 'show' query parameter * Fix show test * refactoring * cleanup * refactor: restructure stats-card code --------- Co-authored-by: Markus <[email protected]> Co-authored-by: Alexandr <[email protected]> Co-authored-by: rickstaa <[email protected]>
Fixes: #1394
Added code reviews to stats card:
What do you think about this feature? They do not affect the rank at the moment, that's something that should be maybe added later. Also translations just default to english.