Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query parameter show #2836

Closed
qwerty541 opened this issue Jun 16, 2023 · 1 comment
Closed

Query parameter show #2836

qwerty541 opened this issue Jun 16, 2023 · 1 comment
Labels
high-priority High priority issue or PR. stats-card Feature, Enhancement, Fixes related to stats the stats card.

Comments

@qwerty541
Copy link
Collaborator

I had doubts that my decision to use &show_total_reviews=true instead of &show=[reviews] inside #1404 was correct. I have looked at the open issues and I assume that in the future such optional data as the number coauthored commits, open and answered discussions etc. may also be added to the statistics card. These changes will lead to an increase in the number of query parameters:

&show_total_reviews=true&show_total_answered_discussions=true&show_total_opened_discussions=true&show_total_coauthored_commits=true

VS

&show=[reviews, answered_discussions, opened_discussions, coauthored_commits]

I think given that this change was made recently and while almost no one is using it, we can change it. What do you think, @rickstaa?
@qwerty541 qwerty541 added stats-card Feature, Enhancement, Fixes related to stats the stats card. high-priority High priority issue or PR. labels Jun 16, 2023
@rickstaa
Copy link
Collaborator

rickstaa commented Jun 16, 2023 •
edited
Loading

I agree! You are welcome to create a pull request for me to review 👍🏻.

qwerty541 added a commit that referenced this issue Jun 17, 2023
@qwerty541
Stats card: migrate from show_total_reviews to show option (resolves #…
c0d9987 
…2836)
HackingGate pushed a commit to HackingGate/github-readme-stats that referenced this issue Jun 25, 2023
@qwerty541 @rickstaa @HackingGate
Stats card: migrate from show_total_reviews to show option (resolves a…
1cbfabe 
…nuraghazra#2836) (anuraghazra#2844)

* Stats card: migrate from show_total_reviews to show option (resolves anuraghazra#2836)

* dev

* docs: improve documentation

---------

Co-authored-by: rickstaa <[email protected]>
devantler pushed a commit to devantler/github-readme-stats that referenced this issue Sep 24, 2023
@qwerty541 @rickstaa @devantler
Stats card: migrate from show_total_reviews to show option (resolves a…
171b809 
…nuraghazra#2836) (anuraghazra#2844)

* Stats card: migrate from show_total_reviews to show option (resolves anuraghazra#2836)

* dev

* docs: improve documentation

---------

Co-authored-by: rickstaa <[email protected]>
setdebarr pushed a commit to setdebarr/github-readme-stats that referenced this issue Jan 12, 2024
@qwerty541 @rickstaa @setdebarr
Stats card: migrate from show_total_reviews to show option (resolves a…
2fcd8c5 
…nuraghazra#2836) (anuraghazra#2844)

* Stats card: migrate from show_total_reviews to show option (resolves anuraghazra#2836)

* dev

* docs: improve documentation

---------

Co-authored-by: rickstaa <[email protected]>
jacobbexten pushed a commit to jacobbexten/github-readme-stats that referenced this issue Nov 6, 2024
@qwerty541 @rickstaa @jacobbexten
Stats card: migrate from show_total_reviews to show option (resolves a…
fb2ba7c 
…nuraghazra#2836) (anuraghazra#2844)

* Stats card: migrate from show_total_reviews to show option (resolves anuraghazra#2836)

* dev

* docs: improve documentation

---------

Co-authored-by: rickstaa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high-priority High priority issue or PR. stats-card Feature, Enhancement, Fixes related to stats the stats card.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rickstaa @qwerty541