Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs : linked PR template #314

Closed
wants to merge 1 commit into from

Conversation

Jyotika999
Copy link
Contributor

@Jyotika999 Jyotika999 commented Oct 18, 2021

Description

Connected PR template to contributing.md

Fixes #230

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have attached link of deployed site.
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@Jyotika999 Jyotika999 mentioned this pull request Oct 18, 2021
11 tasks
@Jyotika999
Copy link
Contributor Author

@isabelcosta please review as suggested by you in previous PR , i have added in the same way

Copy link
Member

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Jyotika999 👏🏾 Thank you for contributing!

@isabelcosta isabelcosta added the Status: Needs Review PR needs an additional review or a maintainer's review. label Oct 18, 2021
Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jyotika999 can you move the contributing.md file from docs to .github folder and just add the template file name instead of hyperlinking it?
So it'll look like this -

Screenshot 2021-10-19 at 11 46 39 PM

@isabelcosta our other repos follow similar structure so just a suggestion :)

@isabelcosta
Copy link
Member

@vj-codes maybe we can make that another issue. just want to make sure we didn't ask more than what was asked initially. If you approve this, I am happy to merge and create the follow up

@Jyotika999 Jyotika999 mentioned this pull request Oct 27, 2021
11 tasks
@Jyotika999
Copy link
Contributor Author

please check #332 , i have added the required details .

@vj-codes
Copy link
Member

Closing this.
To add reviews please look at #332

@vj-codes vj-codes closed this Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review PR needs an additional review or a maintainer's review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR Template in CONTRIBUTING.md doesn't exist
3 participants