Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pr template #332

Merged
merged 5 commits into from
Oct 30, 2021
Merged

Add pr template #332

merged 5 commits into from
Oct 30, 2021

Conversation

Jyotika999
Copy link
Contributor

Description

Added contributing.md to .github folder

Fixes #230

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have attached link of deployed site.
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@Jyotika999
Copy link
Contributor Author

via #314

@Jyotika999 Jyotika999 mentioned this pull request Oct 27, 2021
Closed
11 tasks
vj-codes
vj-codes approved these changes Oct 30, 2021
View reviewed changes
Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @Jyotika999 🎉
LGTM !

@vj-codes vj-codes added the Status: Needs Review PR needs an additional review or a maintainer's review. label Oct 30, 2021
isabelcosta
isabelcosta approved these changes Oct 30, 2021
View reviewed changes
Copy link
Member

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Thank you for contributing @Jyotika999 🙌🏾

@isabelcosta isabelcosta added Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Oct 30, 2021
@isabelcosta isabelcosta merged commit 714dd68 into anitab-org:develop Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vj-codes vj-codes vj-codes approved these changes

@isabelcosta isabelcosta isabelcosta approved these changes

Assignees
No one assigned
Labels
Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PR Template in CONTRIBUTING.md doesn't exist
3 participants
@Jyotika999 @isabelcosta @vj-codes