Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: edit in contributing.md #311

Closed
wants to merge 4 commits into from

Conversation

Jyotika999
Copy link
Contributor

Description

Connected PR template to contributing.md

Fixes #230

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have attached link of deployed site.
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@Jyotika999 Jyotika999 changed the title Add pr template docs: edit in contributing.md Oct 18, 2021
Copy link
Member

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing @Jyotika999 !
I just left a minor comment :)

docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
@Jyotika999
Copy link
Contributor Author

closing via #314

@Jyotika999 Jyotika999 closed this Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR Template in CONTRIBUTING.md doesn't exist
2 participants