-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CI green - disable x86 windows and disable PPStack test on win64 #462
Conversation
Also remove x86 windows from CI
Codecov ReportBase: 76.06% // Head: 78.01% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #462 +/- ##
==========================================
+ Coverage 76.06% 78.01% +1.94%
==========================================
Files 23 23
Lines 1571 1610 +39
==========================================
+ Hits 1195 1256 +61
+ Misses 376 354 -22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sorry for not being able to update and maintain RCall for a while. The test is quite important here to make sure that there is no unbalanced protect / unprotect calls. These calls are used everywhere in RCall. I have used it to catch a few bugs before. Though I am not sure why it fails on Windows. |
Thanks. Good to know. What if I just temporarily disable the test on Windows so that CI passes? |
I think it's fine to skip it on Windows. The mechanism is the same on unix and windows. Though I am not sure why it now fails on Windows. |
@DilumAluthge Do you know how the test for R_PPStackTop fails with R from conda? |
The tests have not passed ever on windows after the migration to github CI, from what I can see in the history. |
Disable conda_provided_r test - This fails on Win64, but perhaps it is ok to not test, since it is just testing threading in the R installation (not RCall itself).
Also remove x86 windows from CI (Addresses #458)
cc @DilumAluthge @randy3k. I think this may be sufficient to get CI to pass and it is ok to not test 32-bit Windows, which is anyways not a Tier 1 supported Julia platform.