-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In CI, use the Conda-provided R #459
Conversation
Codecov ReportBase: 78.01% // Head: 72.72% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #459 +/- ##
==========================================
- Coverage 78.01% 72.72% -5.30%
==========================================
Files 23 23
Lines 1610 1569 -41
==========================================
- Hits 1256 1141 -115
- Misses 354 428 +74
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Failing later now with similar error. |
Can you reproduce the error on a local Windows machine? |
We'll likely need to recruit a Windows user to help. They don't need to set their machine up in a particular way - because we can reproduce this error in CI when |
I might be able to try that out on an underpowered windows machine I do have access to. Although, I thought that removing Conda and just using the CI provided R would be better in terms of fewer dependencies. |
Do you know why it has issues adding General registry? https://github.com/JuliaInterop/RCall.jl/actions/runs/3277858196/jobs/5395606774#step:8:39 |
That looks like a bug in the https://github.com/julia-actions/julia-buildpkg action - I'll look into it. |
So, 64-bit windows is only failing on the conda specific test, which we may be able to disable (or update). The 32-bit windows is failing on finding the right location of the R shared library. If we can get win64 passing, then we can disable win32 for now, and at least get to green CI. |
#462 is an alternate solution. |
On windows 64-bit, I set
However, the correct location is |
Does that mean |
Looks like it: https://github.com/JuliaPy/Conda.jl/blob/8f7133206f3efb6308dff5a2b09393d10e6cc122/src/Conda.jl#L57 I guess we should use
|
@simonbyrne Do we necessarily need to use R <= 4? |
0c4ba06
to
53539b2
Compare
Seems like this would need more work to figure out and we already have a working CI. Just closing it again. |
No description provided.