Update CI to latest practices and fix broken test #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #486 +/- ##
==========================================
+ Coverage 75.67% 76.86% +1.19%
==========================================
Files 24 25 +1
Lines 1640 1664 +24
==========================================
+ Hits 1241 1279 +38
+ Misses 399 385 -14 see 11 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
palday
changed the title
ararslan
approved these changes
Apr 14, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest CI failures all seem related to a single iffy test that was known to be iffy, tested something that isn't in RCall itself, and was already disabled on Windows. xref #462EDIT:Hmmm, I actually might have an idea what's causing that test to fail. Closing this PR until I've investigated further.The fix for the broken test was easy -- check the final stack pointer against the initial stack pointer instead of against 0. I suspect 0 isn't the correct value because of a mixture of various things in R, ASLR, and Docker images being essentially a FreeBSD jail / chroot on steroids.
closes #470
@ViralBShah wanna review since you contributed #462 ?