Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for StatsModels to 0.7, (keep existing compat) #484

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the StatsModels package from 0.6 to 0.6, 0.7.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b4afc92) 76.86% compared to head (0752aa4) 76.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #484   +/-   ##
=======================================
  Coverage   76.86%   76.86%           
=======================================
  Files          25       25           
  Lines        1664     1664           
=======================================
  Hits         1279     1279           
  Misses        385      385           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kleinschmidt
Copy link
Contributor

CI failures seem unrelated (all on ubuntu, failing on a test case that's unrelated AFAICT).

however, sending FunctionTerms to R via exorig is maybe not the best idea since this may not be accurate for FunctionTerms that are constructed outside a @formula (which is now actually possible whereas it was not in 0.6). I don't know what the alternative would be though....one possibility is crawling the function argument tree and building up a Sexp (although it's possible that you'd hit a non-vanilla term in that tree somewhere taht would not have any reasonable Sexp constructor provided...but maybe that's better than hoping that the surface syntax that generated it works the same way in R, I dunno...)

@palday
Copy link
Collaborator

palday commented Apr 13, 2023

This passes locally on my Ubuntu-derivative machine, might be worthwhile to just restart CI. It would be nice to have this compat bump released.

…helper/new_version/2023-03-15-00-43-31-892-00257834843
@palday
Copy link
Collaborator

palday commented Apr 14, 2023

image

@kleinschmidt I fixed CI in #486 -- do you want to give a 👍 as StatsModels rep?

@palday palday merged commit b38c31f into master Apr 14, 2023
@palday palday deleted the compathelper/new_version/2023-03-15-00-43-31-892-00257834843 branch April 14, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants