Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor_global_as_function_inputs #175

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

refactor_global_as_function_inputs #175

wants to merge 4 commits into from

Conversation

yijianzeng
Copy link
Contributor

@yijianzeng yijianzeng commented May 24, 2023

Description

Refactor the global variables into function inputs. This is related to issue #165

Update executable file

Please re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.

Checklist

  • Add a reference to related issues.
  • @mentions of the person or team responsible for reviewing proposed changes.
  • This pull request has a descriptive title.
  • Code is written according to the guidelines.
  • The checks by MISS_HIT style checker and linter, below the pull request, are successful (green).
  • Documentation is available.
  • Model runs successfully.

@yijianzeng yijianzeng marked this pull request as ready for review May 24, 2023 14:19
Copy link
Contributor

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Yijian, it seems that the changes you made lead to some difference in the model result.
This is probably not intentional.

Below is a plot of the difference in soil temperature and soil moisture between the main branch, and this branch:
image

src/+equations/calc_rssrbs.m Show resolved Hide resolved
@SarahAlidoost
Copy link
Member

@yijianzeng are you still working on this pull request?

@yijianzeng
Copy link
Contributor Author

@yijianzeng are you still working on this pull request?

Hi Sarah, i didnt manage to have the test script running on CRIB. I will check with Bas Retsios on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants