Fix ChoiceField when entity is enumType and no choices were given #5944
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ChoiceField when entity is enumType and no choices were given explicitly
Bugs
BUG: if
setChoices
is not called on the ChoiceField, and the backing entity field is an Enum, the dropdown displays 0, 1, 2, 3, etc., because the$choices
array ends up like this:BUG: Symfony Forms attempts to convert the enum to string.
Fixes
Fix the ChoiceConfigurator
This PR fixes the ChoiceConfigurator to behave as if
->setChoices(MyEnum::cases())
were called.Related to commit 65a422b of PR #5879 by @SerheyDolgushev
Fix the forms
Although closed, bug #5641 was not addressed by PR #5879. Without the change suggested by the original reported, the following errors are thrown:
The EDIT action of a CRUD that contains a ChoiceField with an enum:
Object of class App\Enum\ProjectTypeEnum could not be converted to string
The Create action of a CRUD that contains a ChoiceField with an enum (the NEW page doesn't complain until submitted):
Expected argument of type "App\Enum\ProjectTypeEnum", "string" given at property path "type".