Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Gitignore to ignore .idea folders as its keep getting commited #5983

Conversation

bytes-commerce
Copy link
Contributor

Albeit its an software-specific adaptation, I feel that the idea folder should be ignored on this project; it keeps getting committed to the repository by accident and this simple change would stop that behavior for once.

Eventually, it will be less work for maintainers to remove them, once wrongfully committed.

@bytes-commerce bytes-commerce changed the title Adapt Gitignore to ignore idea folders as its keep getting commited Adapt Gitignore to ignore .idea folders as its keep getting commited Oct 27, 2023
@OskarStark
Copy link
Collaborator

I am 👎 on this change, this should go in your local global .gitignore file. We cannot ignore all folders for all available IDEs.

@bytes-commerce
Copy link
Contributor Author

There aren't so many popular IDEs that it would make a difference to include even the 5 most used ones; and it doesn't reduce the quality of the code either, instead it only makes working with the project easier for maintainers and people who contribute otherwise.

Just recently it got merged and reverted:
Merge: #5944
Revert: dd8a6f0

Which is just much more work to do in reviewing AND reverting than just having this line in the .gitignore. Its tedious work to repeat yourself in PRs when people commit it, and it can just be stopped by a very simple change.

@OskarStark
Copy link
Collaborator

I let @javiereguiluz decide here

@bytes-commerce
Copy link
Contributor Author

I think if the community has some strong feelings against it, its perfectly fine to close it, either. Its not a PR that took me long time to prepare. :D

@javiereguiluz
Copy link
Collaborator

@NopeNopeNope you are right that PhpStorm is very popular and that makes it special ... but the best practice recommended in the Symfony community is to add this kind of ignore in the global .gitignore file, as Oskar said. We always try to follow the same practices as Symfony in this repo (sometimes we can't do that because we have less resources 🙏) so, let's close as "won't merge". Thanks!

Here's a good resource about setting up global ignore files if anyone needs it: https://gist.github.com/subfuzion/db7f57fff2fb6998a16c

@bytes-commerce bytes-commerce deleted the remove-ide-specific-folders-from-repository branch October 27, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants