Add support for Enums in Choice fields

[javiereguiluz]

No description provided.

[javiereguiluz]

I've fixed a couple of tests, but there's a test that still fails.

To be honest, I don't even understand what I'm doing. I don't work much with Enums, so this is still confusing to me. Hopefully @abozhinov or @ksn135 can take a look here and suggest some fixes. Thanks.

[ksn135]

Hi @javiereguiluz !
Sorry for the delay in replying.
I applied the patch to the current master 4.x branch and everything works fine in my projects as follows:
In lists and in view mode, the translated value is shown. In edit or create mode, a selection item appears with the same correctly translated caption. It seems to me it is possible to merge with the main branch.



New code WITH this patch:

        yield Fields\ChoiceField::new('priority', 'admin_label.doc.field.priority')->setRequired(true)
            ->setFormTypeOption('choice_label', fn ($choice, $key, $value) => 'admin_label.enum.docPriority.'. $value);

Current version of VERY ugly BUT working code:

        yield Fields\ChoiceField::new('priority', 'admin_label.doc.field.priority')->setRequired(true)
            ->setFormTypeOption('placeholder', false)
            ->setFormType(MyEnumType::class) // use transformer to convert enum to string and back
            ->setFormTypeOption('class', DocPriority::class) // needed for MyEnumType
            ->setChoices( // to correctly show translated labels
                        \in_array($pageName, [Crud::PAGE_INDEX, Crud::PAGE_DETAIL], true)
                                    ? DocPriority::choices() : DocPriority::cases()); 

P.S.: I don't really understand why that test crashes either, unfortunately. I'll try to figure it out a little later.
P.P.S.: Please review my old PR #5495 and give me feedback about it.

[ksn135]

Hi @javiereguiluz ! There is no FAILING test. Just run it locally.

[abozhinov]

Hi @javiereguiluz and @ksn135,
I wanted to discuss the goals of this pull request (PR) with you:

1. The first goal is to enable the hiding of fields from the Configurator.
2. The second goal is to transform ChoiceField to EnumField when an Enum is being used.
   Let me know if you have any questions or suggestions.

[abozhinov]

Without changes in the ChoiceConfigurator has following error:
Symfony\Component\Form\Extension\Core\Type\EnumType::Symfony\Component\Form\Extension\Core\Type\{closure}(): Argument #1 ($choice) must be of type ?BackedEnum, string given, called in /var/www/html/dreamshop/vendor/symfony/form/ChoiceList/ArrayChoiceList.php on line 181

yield ChoiceField::new('type', new TranslatableMessage('product.attribute.type.label')) ->setChoices($isInfoPage ? ProductAttributeType::getAsArray() : ProductAttributeType::cases()) ->setFormType(EnumType::class) ->setFormTypeOption('class', ProductAttributeType::class) ->setFormTypeOption('choice_label', function (ProductAttributeType $enum) { return 'product.attribute.type.'.$enum->value; }) ->setCustomOption(ChoiceField::OPTION_USE_TRANSLATABLE_CHOICES, $isInfoPage) ->setDisabled() ->setVirtual(true);

[abozhinov]

yield ChoiceField::new('type', new TranslatableMessage('package.type.label')) ->setFormTypeOption('choice_label', function (PackageType $enum) { return 'package.type.'.$enum->value; }) ->setCustomOption(ChoiceField::OPTION_USE_TRANSLATABLE_CHOICES, $isInfoPage);

[abozhinov]

Should also add && !$field->getFormTypeOption('choice_label')

[abozhinov]

Will anyone merge this changes to main branch?

[abozhinov]

You can close this PR because I create new #5867 with all tests Passed.

[javiereguiluz]

Closing in favor of #5944. Hopefully it fixes problems for good 🙏 Thanks!