Fix ChoiceField Enum support and control field visibility inside Configurator #5640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 18, 2023
| @@ -99,6 +99,12 @@ public function processFields(EntityDto $entityDto, FieldCollection $fields): vo | |||
|
|
|||
| $configurator->configure($fieldDto, $entityDto, $context); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Is this code really needed? We have the same code a few lines above.
There was a problem hiding this comment.
It's needed because you need to control the display option inside the configurator.
|
Thanks Alexandar! I'm going to merge this, but I've created a new PR (#5740) to rebase, squash commits and do other minor tweaks. Your original commit is preserved so you'll get full credit of your contribution. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.