Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add surface flux rollover #394

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Conversation

jedwards4b
Copy link
Collaborator

Description of changes

Add rollover of surface fluxes at high wind speed.

Specific notes

Contributors other than yourself, if any: zarzycki

CMEPS Issues Fixed: #393

Are changes expected to change answers? possibly more substantial

Any User Interface Changes (namelist or namelist defaults changes)? NO

Testing performed

Please describe the tests along with the target model and machine(s)
If possible, please also added hashes that were used in the testing

@cacraigucar
Copy link
Contributor

After speaking with the AMP scientists, we want to have @cecilehannay make a 5 year FHIST 1 degree run and evaluate the impacts before we accept this change.

@cacraigucar
Copy link
Contributor

@cecilehannay - Have you been able to make this run (no pressure - I'm just checking to see if it is done and I've not heard about it)

@cacraigucar
Copy link
Contributor

Awaiting feedback from @PeterHjortLauritzen on the outcome of the run: NCAR/amwg_dev#384 (comment)

@PeterHjortLauritzen
Copy link

No issues apparent to me in diagnostics. Thanks for fixing: @vlarson, @zarzycki, @jedwards4b

Copy link
Contributor

@cacraigucar cacraigucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on Peter's review, I am approving these changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rollover of surface fluxes (cdn) at high wind speed
3 participants