cam6_3_132: Changes to capture changes made in run 51 #900

cacraigucar · 2023-10-10T20:47:16Z

Closes #895

cloud ice fraction changes for cam_dev

…ct latest tunings

added namelists for wsub_min_asf, modified namelist defaults to refle…

adamrher

I have one concern about using cam_dev as the logical for the new ice fraction mods.

src/physics/cam/cldfrc2m.F90

PeterHjortLauritzen · 2023-10-12T18:04:24Z

I have one concern about using cam_dev as the logical for the new ice fraction mods.

Agreed (the initial implementation of do_hb_above_clubb used cam_physpkg_is("cam_dev") as a specifier but I changed it to namelist for the PR).

adamrher · 2023-10-12T18:09:34Z

Agreed (the initial implementation of do_hb_above_clubb used cam_physpkg_is("cam_dev") as a specifier but I changed it to namelist for the PR).

OK, I am going to make a namelist called cldfrc2m_do_avg_aist_algs since what these mods do is average two different aist algorithms. Will do this after my 1PM mtg.

PeterHjortLauritzen

Just one minor namelist comment.

Thanks @adamrher and @cacraigucar

PeterHjortLauritzen · 2023-10-12T18:45:28Z

bld/namelist_files/namelist_defaults_cam.xml

@@ -2065,9 +2065,11 @@
 <clubb_do_energyfix                               > .true.  </clubb_do_energyfix>
 <clubb_do_liqsupersat                             > .false. </clubb_do_liqsupersat>
 <clubb_gamma_coef                                 > 0.308   </clubb_gamma_coef>
+<clubb_gamma_coef phys="cam_dev"                  > 0.3     </clubb_gamma_coef>
 <clubb_gamma_coef hgrid="1.9x2.5" phys="cam6"     > 0.280   </clubb_gamma_coef>
 <clubb_gamma_coef dyn="se"                        > 0.270   </clubb_gamma_coef>


Should we remove

<clubb_gamma_coef dyn="se" > 0.270 </clubb_gamma_coef>

?

That's a good catch actually because it results in a tie if you run w/ cam_dev and se. We can either do away with it entirely, or specify it further to refer to how se is configured for cam6 in the CESM2.2 JAMES paper:

<clubb_gamma_coef dyn="se" phys="cam6" > 0.270 </clubb_gamma_coef>

I'd seen that and confirmed that the first one appeared to beat out the later one. Can we just delete the <clubb_gamma_coef dyn="se" phys="cam6" > 0.270 </clubb_gamma_coef> as it is captured in the CESM2.2 branch for archival purposes?

Good point. Yes, I concur with deleting it entirely from cam_development.

This is resolved in PR pending to this branch. Note that removing this line will cause a lot of baseline failures.

… default

swap cam_dev conditional for a new namelist, remove se gamma namelist…

nusbaume

Looks good, just have some minor variable comment/description cleanup.

bld/namelist_files/namelist_definition.xml

src/physics/cam/cldfrc2m.F90

nusbaume

Everything looks good to me now, thanks!

cacraigucar · 2023-10-16T20:25:30Z

@adamrher - Here is the fix I implemented for the failing SPCAM regression test. a35cef1
The test now passes with this fix. Let me know if you approve of the change.

adamrher · 2023-10-16T20:33:20Z

Looks good to me @cacraigucar. I might just add a comment explaining that wsub_min_asf is:

! minimum sub-grid vertical velocity

cacraigucar · 2023-10-17T17:03:16Z

Answer change mystery solved (by @fischer-ncar). There is a CMEPS update which is answer changing. It is because of ESCOMP/CMEPS#394. This change was signed off on by @PeterHjortLauritzen a little over a month ago. The upcoming CESM tag will defintely have this. Is it okay to have the CAM tag have this answer change as well at this time?

If so, my plan is to proceed with making cam6_3_131 with the updated externals and then rereunning the regression tests for this PR. The answer changes should be limited to cam_dev at this point.

Thoughts?
@cecilehannay @adamrher @PeterHjortLauritzen

adamrher · 2023-10-17T17:10:12Z

@cacraigucar that sounds like a good plan. Fingers crossed that most non-cam_dev baselines don't fail when you do the new regression tests for the 51 changes.

cacraigucar · 2023-10-17T17:24:03Z

@cacraigucar that sounds like a good plan. Fingers crossed that most non-cam_dev baselines don't fail when you do the new regression tests for the 51 changes.

Based on @adamrher approval of my workflow and @PeterHjortLauritzen's previous approval, I am proceeding to make cam6_3_131 with the updated externals. I will then startup regression testing on this PR.

cecilehannay · 2023-10-17T17:30:47Z

It sounds good. We also talked at the CESM meeting about creating a new CESM tag using this new cam tag + any changes to MOM the oceanographers want. (@gustavo-marques, @jedwards4b)

cam6_3_131

PeterHjortLauritzen · 2023-10-17T18:09:56Z

Sounds good to include the CMEPS change! Approved ...

Merge pull request ESCOMP#900 from cacraigucar/cam_match_run_51 cam6_3_132: Changes to capture changes made in run 51 ESCOMP commit: 5ddccd8

namelist changes to match run 51

f4ec0be

cacraigucar self-assigned this Oct 10, 2023

cacraigucar marked this pull request as draft October 10, 2023 20:47

adamrher and others added 4 commits October 10, 2023 15:06

cloud ice fraction changes for cam_dev

221dc72

Merge pull request #16 from adamrher/cam_match_run_51.arh

46b65e2

cloud ice fraction changes for cam_dev

added namelists for wsub_min_asf, modified namelist defaults to refle…

dd69c5d

…ct latest tunings

Merge pull request #17 from adamrher/cam.wmixmin

64f5873

added namelists for wsub_min_asf, modified namelist defaults to refle…

cacraigucar marked this pull request as ready for review October 12, 2023 17:34

cacraigucar requested review from adamrher, PeterHjortLauritzen, JulioTBacmeister, cecilehannay and nusbaume October 12, 2023 17:35

adamrher reviewed Oct 12, 2023

View reviewed changes

src/physics/cam/cldfrc2m.F90 Outdated Show resolved Hide resolved

src/physics/cam/cldfrc2m.F90 Outdated Show resolved Hide resolved

PeterHjortLauritzen approved these changes Oct 12, 2023

View reviewed changes

adamrher and others added 2 commits October 12, 2023 14:51

swap cam_dev conditional for a new namelist, remove se gamma namelist…

84a256d

… default

Merge pull request #18 from adamrher/cam.aistnl

22f5897

swap cam_dev conditional for a new namelist, remove se gamma namelist…

adamrher approved these changes Oct 12, 2023

View reviewed changes

nusbaume requested changes Oct 13, 2023

View reviewed changes

bld/namelist_files/namelist_definition.xml Outdated Show resolved Hide resolved

bld/namelist_files/namelist_definition.xml Outdated Show resolved Hide resolved

src/physics/cam/cldfrc2m.F90 Show resolved Hide resolved

src/physics/cam/cldfrc2m.F90 Outdated Show resolved Hide resolved

cacraigucar added 2 commits October 13, 2023 14:34

Update externals to allow for derecho priority setting

e28d2bc

address review requests

672aaf1

cacraigucar requested a review from nusbaume October 13, 2023 20:43

cacraigucar added 2 commits October 13, 2023 15:05

Change namelist based on verbal request from Adam, Cecile and Peter

c50fcc6

Change PE layout to fix some derecho failures

8b7a4ea

cacraigucar removed request for JulioTBacmeister and cecilehannay October 14, 2023 00:58

nusbaume approved these changes Oct 14, 2023

View reviewed changes

Fix failing SPCAM test

a35cef1

cacraigucar changed the title ~~Changes to capture changes made in run 51~~ cam6_3_132: Changes to capture changes made in run 51 Oct 16, 2023

Merge tag 'cam6_3_131' into cam_match_run_51

7139631

cam6_3_131

ChangeLog for cam6_3_132

311a23d

cacraigucar merged commit 5ddccd8 into ESCOMP:cam_development Oct 18, 2023

cacraigucar deleted the cam_match_run_51 branch October 18, 2023 15:42

gold2718 pushed a commit to gold2718/CAM that referenced this pull request May 2, 2024

ESCOMP tag: cam6_3_132

6eb0471

Merge pull request ESCOMP#900 from cacraigucar/cam_match_run_51 cam6_3_132: Changes to capture changes made in run 51 ESCOMP commit: 5ddccd8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cam6_3_132: Changes to capture changes made in run 51 #900

cam6_3_132: Changes to capture changes made in run 51 #900

cacraigucar commented Oct 10, 2023

adamrher left a comment

PeterHjortLauritzen commented Oct 12, 2023 •

edited

Loading

adamrher commented Oct 12, 2023

PeterHjortLauritzen left a comment

PeterHjortLauritzen Oct 12, 2023

adamrher Oct 12, 2023 •

edited

Loading

cacraigucar Oct 12, 2023 •

edited

Loading

adamrher Oct 12, 2023

adamrher Oct 12, 2023

nusbaume left a comment

nusbaume left a comment

cacraigucar commented Oct 16, 2023

adamrher commented Oct 16, 2023

cacraigucar commented Oct 17, 2023

adamrher commented Oct 17, 2023

cacraigucar commented Oct 17, 2023

cecilehannay commented Oct 17, 2023

PeterHjortLauritzen commented Oct 17, 2023

cam6_3_132: Changes to capture changes made in run 51 #900

cam6_3_132: Changes to capture changes made in run 51 #900

Conversation

cacraigucar commented Oct 10, 2023

adamrher left a comment

Choose a reason for hiding this comment

PeterHjortLauritzen commented Oct 12, 2023 • edited Loading

adamrher commented Oct 12, 2023

PeterHjortLauritzen left a comment

Choose a reason for hiding this comment

PeterHjortLauritzen Oct 12, 2023

Choose a reason for hiding this comment

adamrher Oct 12, 2023 • edited Loading

Choose a reason for hiding this comment

cacraigucar Oct 12, 2023 • edited Loading

Choose a reason for hiding this comment

adamrher Oct 12, 2023

Choose a reason for hiding this comment

adamrher Oct 12, 2023

Choose a reason for hiding this comment

nusbaume left a comment

Choose a reason for hiding this comment

nusbaume left a comment

Choose a reason for hiding this comment

cacraigucar commented Oct 16, 2023

adamrher commented Oct 16, 2023

cacraigucar commented Oct 17, 2023

adamrher commented Oct 17, 2023

cacraigucar commented Oct 17, 2023

cecilehannay commented Oct 17, 2023

PeterHjortLauritzen commented Oct 17, 2023

PeterHjortLauritzen commented Oct 12, 2023 •

edited

Loading

adamrher Oct 12, 2023 •

edited

Loading

cacraigucar Oct 12, 2023 •

edited

Loading