Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Camera/AP_Mount: camera info msg gets device id to improve multi camera support #24551

Merged
merged 8 commits into from
Aug 10, 2023

Conversation

rmackay9
Copy link
Contributor

@rmackay9 rmackay9 commented Aug 9, 2023

This is a rebased version of PR #24354

This PR allows ground station to know which camera is in which gimbal

There is an additional drive-by enhancement to vehicle's actual z-axis rotation rate which only affects MAVLink enabled gimbals which means the Gremsy gimbals.

This has been lightly tested on real hardware including a Gremsy PixyU. Testing included:

  • Added debug messages to confirm that the expected "gimbal_device_id" was sent when using a Siyi A8. MP's mavlink inspector does not yet know about this new field yet because it is still using the older mavlink definitions
  • Added debug to output the AHRS yaw rate and then moved the vehicle around to confirm the expected values were output. Also tested that the PixyU still moved as expected.

@Davidsastresas, @khanasif786, @peterbarker could you confirm that you're happy with this PR?

@rmackay9 rmackay9 force-pushed the davidsastresas-camer-info-msg branch from 42994c1 to e6e217c Compare August 9, 2023 05:21
@Davidsastresas
Copy link
Contributor

Thanks Randy!

@rmackay9 rmackay9 merged commit 7677103 into ArduPilot:master Aug 10, 2023
81 checks passed
@rmackay9 rmackay9 deleted the davidsastresas-camer-info-msg branch August 10, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants