Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding option to separate implicit mod release from key release #2334

Merged
merged 2 commits into from
Jun 24, 2024
Merged

fix: adding option to separate implicit mod release from key release #2334

merged 2 commits into from
Jun 24, 2024

Commits on Jun 14, 2024

  1. fix: adding option to separate implicit mod release from key release 

    This adds a new config value `ZMK_HID_SEPARATE_MOD_RELEASE_REPORT`
where, if enabled, the report for a key release is sent separately to
the accompanying modifier release signals, which are then sent in a
second report.

This fixes an issue where certain applications are unable to work with
implicitly modified keys (e.g. colon) due to them registering the
modifier release prior to the actual key release.

Have tested this on my personal keyboard and `wev` now shows the signals
in the correct order.

=> **Previously:** ```LSHIFT (pressed) -> colon (pressed) -> LSHIFT
(released) -> **semi**colon (released)```

=> **Now:** ```LSHIFT (pressed) -> colon (pressed) -> colon (released)
-> LSHIFT (released)```

(This time without accidental files)
    @Timoyoungster
    Timoyoungster committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    72ea410 View commit details
    Browse the repository at this point in the history

  2. docs: hopefully more clear description of the new setting

    @Timoyoungster
    Timoyoungster committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    70b907c View commit details
    Browse the repository at this point in the history