fix: adding option to separate implicit mod release from key release #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caksoylar
reviewed
Jun 13, 2024
petejohanson
requested changes
Jun 14, 2024
docs/package-lock.json
Outdated
| @@ -4897,11 +4897,12 @@ | |||
| } | |||
| }, | |||
| "node_modules/braces": { | |||
| "version": "3.0.2", | |||
There was a problem hiding this comment.
Please take this file change out of this commit/PR.
There was a problem hiding this comment.
I'll try👍
Sorry about that.
This adds a new config value `ZMK_HID_SEPARATE_MOD_RELEASE_REPORT` where, if enabled, the report for a key release is sent separately to the accompanying modifier release signals, which are then sent in a second report. This fixes an issue where certain applications are unable to work with implicitly modified keys (e.g. colon) due to them registering the modifier release prior to the actual key release. Have tested this on my personal keyboard and `wev` now shows the signals in the correct order. => **Previously:** ```LSHIFT (pressed) -> colon (pressed) -> LSHIFT (released) -> **semi**colon (released)``` => **Now:** ```LSHIFT (pressed) -> colon (pressed) -> colon (released) -> LSHIFT (released)``` (This time without accidental files)
Timoyoungster
force-pushed
the
implicit-mods
branch
from
3989ec7
to
72ea410
Compare
|
@petejohanson is the phrasing ok now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new config value
ZMK_HID_SEPARATE_MOD_RELEASE_REPORTwhere, if enabled, the report for a key release is sent separately to the accompanying modifier release signals, which are then sent in a second report.This fixes an issue where certain applications are unable to work with implicitly modified keys (e.g. colon) due to them registering the modifier release prior to the actual key release.
Have tested this on my personal keyboard and
wevnow shows the signals in the correct order.=> Previously:
LSHIFT (pressed) -> colon (pressed) -> LSHIFT (released) -> **semi**colon (released)=> Now:
LSHIFT (pressed) -> colon (pressed) -> colon (released) -> LSHIFT (released)