Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: mps3: Add support for corstone300/an552 and corstone310/an555 #79127

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wearyzen
Copy link
Contributor

@wearyzen wearyzen commented Sep 27, 2024

What is changed?

  • Added a new mps3 board an552 for the soc corstone300. an552 uses ARM FVP (FVP_Corstone_SSE-300_Ethos-U55). The qualifier to build/run application with board mps3/an552 is
    mps3/corstone300/an552 for secure and mps3/corstone300/an552/ns for non-secure.
  • Added a new mps3 board an555 for the soc corstone310 to enable testing with ARM FVP (FVP_Corstone_SSE-310).
    The qualifier to build/run application with board mps3/an555 is mps3/corstone310/an555 for secure and mps3/corstone310/an555/ns for non-secure.
  • MPS3 board documentation was modified to include all 3 boards.
  • Note: the qualifier to build/run application with board mps3/an547 is now changed to mps3/corstone300/an547 for secure and mps3/corstone300/an547/ns for non-secure.

How is it changed?

  • Extracted common code for mps3/an547 and mps3/an552 as corstone300.
  • Renamed soc for an547 to corstone300 and added a new soc corstone300/an552 and corstone310/an555.

Why do we need this change?

  • This enables FVP support and testing for mps3/an552 and mps3/an555.
  • SOC/qualifier for mps3/an547 was renamed to reduce code redundancy.

Signed-off-by: Sudan Landge [email protected]

@dcpleung
Copy link
Member

Could you also add a note in the next release note about the renaming of mps3/an547 to mps3/corstone300/547?

ithinuel
ithinuel previously approved these changes Sep 28, 2024
ithinuel
ithinuel previously approved these changes Sep 30, 2024
boards/arm/mps3/doc/mps3_an547.rst Outdated Show resolved Hide resolved
boards/arm/mps3/doc/mps3_an552.rst Outdated Show resolved Hide resolved
@wearyzen wearyzen force-pushed the add_mps3_board_an552_an555 branch 2 times, most recently from 6ff6ca2 to d8040a5 Compare October 2, 2024 10:50
@wearyzen wearyzen marked this pull request as draft October 2, 2024 21:01
@wearyzen
Copy link
Contributor Author

wearyzen commented Oct 2, 2024

Few more changes were identified so converting this to a draft.

What is changed?
 - Added a new mps3 board an552 for the soc corstone300.
   The qualifier to build/run application with board mps3/an552 is
   `mps3/corstone300/an552` for secure and
   `mps3/corstone300/an552/ns` for non-secure.
 - Added FVP variant to enable FVP testing with corstone300
   and it uses the ARM FVP `FVP_Corstone_SSE-300_Ethos-U55`.
   The qualifier to build/run application with FVP is
   `mps3/corstone300/fvp` for secure and
   `mps3/corstone300/fvp/ns` for non-secure.
 - Note: the qualifier to build/run application with board mps3/an547
   is now changed to
   `mps3/corstone300/an547` for secure and
   `mps3/corstone300/an547/ns` for non-secure.

How is it changed?
 - Moved common code from mps3/an547 to corstone300.
 - Renamed soc for an547 to corstone300 and added
   a new soc corstone300/an552.

Why do we need this change?
 - This enables FVP support and testing for corstone300.
 - SOC/qualifier for mps3/an547 was renamed to reduce code redundancy
 - A separate FVP variant was added for AN552 because, the TFM board
   used for non-secure variant differs for FPGA and FVP.
   TFM board `arm/mps3/corstone300/fvp` should be used when testing
   AN552 with FVP and `arm/mps3/corstone300/an552` should be used when
   testing with AN552 FPGA.

Signed-off-by: Sudan Landge <[email protected]>
What is changed?
 - Added a new mps3 board an555 for the soc corstone310.
   The qualifier to build/run application with board mps3/an555 is
   `mps3/corstone310/an555` for secure and
   `mps3/corstone310/an555/ns` for non-secure.
 - Added FVP variant to enable FVP testing with corstone310
   and it uses the ARM FVP `FVP_Corstone_SSE-310`.
   The qualifier to build/run application with FVP is
   `mps3/corstone310/an555fvp` for secure and
   `mps3/corstone310/an555fvp/ns` for non-secure.

Why do we need this change?
 - This enables FVP support and testing for corstone310.
 - A separate FVP variant was added for AN555 because, the TFM board
   used for non-secure variant differs for FPGA and FVP.
   TFM board `arm/mps3/corstone310/an555` should be used when testing
   AN555 with FVP and `arm/mps3/corstone310/fvp` should be used when
   testing with AN555 FPGA.

Signed-off-by: Sudan Landge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants