-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hwmv2: Added Board Support for Starfive VisionFive2 RISC-V Single Board Computer #69808
Conversation
This is the rebased version of #69676. As per the maintainers requirements to rebase the PR. We created a new PR which points from |
cc @cfriedt Milk-V Mars |
I think what @nordicjm meant in #69676 is to rebase the changes on top of The general practice is to create a branch from Taking this PR as an example, I'd create a branch named |
@ycsin Agreed! Thanks for the insight, we will take care of that from next time : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't go thru everything yet, but please have a look at #64161 and plan the commits properly, i.e. you should be adding dts bindings first, then soc
, drivers
and finally boards
Please don't create another PR, so that things are easier to trace. You should do your changes in the current branch, rewrite the git history and force push them to github
Just in case you didn't already know - rebasing is pretty easy if you are using vscode:
- checkout your PR branch (in this case -
pfarwsi:main
) - fetch upstream main branch
- right click
zephyr:main
branch and selectRebase Current Branch onto Branch
- ctrl + shift + p: Git: Push (force)
Hi @pfarwsi! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
that's awkward - I'm not sure if pushing commits to the |
@kanakshilledar it seems like the problem may be that you have created this PR from your own forks main branch, and your forks main branch has been updated to match Zephyr's main a couple of minutes ago? (effectively making this PR a no-op) |
These list of patches contain Board support files for running Zephyr on the Starfive VisionFive2 RISC-V Single Board Computer based on JH7110 SOC. It's a basic support, no drivers other than UART have been tested.