-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stm32h503 does not enable the driver if instance is not present #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRASTM
added a commit
to FRASTM/zephyr
that referenced
this pull request
Nov 16, 2023
Update the stm32h5xx/drivers/include/ to enable the SAI, DelayBlock and DCACHE only if the instance exists in the soc. Which is not the case for stm32h503x device zephyrproject-rtos/hal_stm32#181 Signed-off-by: F. Ramu <[email protected]>
erwango
requested changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide ST internal reference and document fix in README file
Include the stm32H5 HAL SAI driver only if instance SAI_block A or B exist in the stm32H5 soc (not on stm32h50x) Signed-off-by: F. Ramu <[email protected]>
Include the stm32H5 HAL DCACHE driver only if instance DCACHE1 exists in the stm32H5 soc (not on stm32h50x) Signed-off-by: F. Ramu <[email protected]>
Include the stm32H5 HAL DLYB driver only if instance SDMMC or OCTOSPI exist in the stm32H5 soc (not on stm32h50x) Signed-off-by: F. Ramu <[email protected]>
List the changes to the stm32CubeH5 driver for this PR Signed-off-by: F. Ramu <[email protected]>
Updating the stm32cube/stm32h5xx/README |
erwango
approved these changes
Nov 17, 2023
gautierg-st
approved these changes
Nov 17, 2023
FRASTM
added a commit
to FRASTM/zephyr
that referenced
this pull request
Nov 20, 2023
Update the stm32h5xx/drivers/include/ to enable the SAI, DelayBlock and DCACHE only if the instance exists in the soc. Which is not the case for stm32h503x device zephyrproject-rtos/hal_stm32#181 Signed-off-by: F. Ramu <[email protected]>
FRASTM
added a commit
to FRASTM/zephyr
that referenced
this pull request
Nov 20, 2023
Update the stm32h5xx/drivers/include/ to enable the SAI, DelayBlock and DCACHE only if the instance exists in the soc. Which is not the case for stm32h503x device zephyrproject-rtos/hal_stm32#181 Signed-off-by: F. Ramu <[email protected]>
FRASTM
added a commit
to FRASTM/zephyr
that referenced
this pull request
Nov 20, 2023
Update the stm32h5xx/drivers/include/ to enable the SAI, DelayBlock and DCACHE only if the instance exists in the soc. Which is not the case for stm32h503x device zephyrproject-rtos/hal_stm32#181 Signed-off-by: Francois Ramu <[email protected]>
carlescufi
pushed a commit
to zephyrproject-rtos/zephyr
that referenced
this pull request
Nov 22, 2023
Update the stm32h5xx/drivers/include/ to enable the SAI, DelayBlock and DCACHE only if the instance exists in the soc. Which is not the case for stm32h503x device zephyrproject-rtos/hal_stm32#181 Signed-off-by: Francois Ramu <[email protected]>
coreboot-org-bot
pushed a commit
to coreboot/zephyr-cros
that referenced
this pull request
Nov 22, 2023
Update the stm32h5xx/drivers/include/ to enable the SAI, DelayBlock and DCACHE only if the instance exists in the soc. Which is not the case for stm32h503x device zephyrproject-rtos/hal_stm32#181 (cherry picked from commit 4ddbf51) Original-Signed-off-by: Francois Ramu <[email protected]> GitOrigin-RevId: 4ddbf51 Change-Id: I55ca96bd043ba6b6c729d359ad1d45211d34efd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5053132 Tested-by: Tristan Honscheid <[email protected]> Tested-by: ChromeOS Prod (Robot) <[email protected]> Reviewed-by: Tristan Honscheid <[email protected]> Commit-Queue: Tristan Honscheid <[email protected]>
yunheQin
pushed a commit
to yunheQin/zephyr
that referenced
this pull request
Dec 6, 2023
Update the stm32h5xx/drivers/include/ to enable the SAI, DelayBlock and DCACHE only if the instance exists in the soc. Which is not the case for stm32h503x device zephyrproject-rtos/hal_stm32#181 Signed-off-by: Francois Ramu <[email protected]>
panxxhub
pushed a commit
to panxxhub/zephyr
that referenced
this pull request
Dec 7, 2023
Update the stm32h5xx/drivers/include/ to enable the SAI, DelayBlock and DCACHE only if the instance exists in the soc. Which is not the case for stm32h503x device zephyrproject-rtos/hal_stm32#181 Signed-off-by: Francois Ramu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stm32h503 soc does not embed delayblock (DLYB) or SAI block or DCACHE instances.
Consequently the corresponding drivers should be included.