Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .pre-commit-config mypy + bump ruff version #211

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

norlandrhagen
Copy link
Collaborator

@norlandrhagen norlandrhagen commented Aug 5, 2024

In #180, it seems like the Github pre-commit CI wasn't working on PR's. I enabled the app in the repo (08-05-2024). This is a tiny PR that bumps a ruff version & updates the .pre-commit-config.yaml mypy section to replace types-pkg_resources with types-setuptools.

@norlandrhagen norlandrhagen changed the title Bump ruff version Update .pre-commit-config mypy + bump ruff version Aug 5, 2024
@norlandrhagen
Copy link
Collaborator Author

Note: pre-commit is failing to upstream typing errors that were missed in linting.

virtualizarr/zarr.py:138: error: Function "virtualizarr.zarr.ZArray.dict" is not valid as a type  [valid-type]
virtualizarr/zarr.py:138: note: Perhaps you need "Callable[...]" or a callback protocol?
virtualizarr/tests/test_zarr.py:43: error: Argument "filetype" to "open_virtual_dataset" has incompatible type "str"; expected "FileType | None"  [arg-type]
Found 2 errors in 2 files (checked 23 source files)

Copy link
Collaborator

@TomNicholas TomNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @norlandrhagen ! We'll fix the now-exposed typing errors separately.

@TomNicholas TomNicholas merged commit 3765243 into main Aug 5, 2024
7 of 8 checks passed
@TomNicholas TomNicholas deleted the pre-commit/ruff_version_bump branch August 5, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants