Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically run pre-commit on all PRs #180

Closed
TomNicholas opened this issue Jul 9, 2024 · 2 comments
Closed

Automatically run pre-commit on all PRs #180

TomNicholas opened this issue Jul 9, 2024 · 2 comments
Labels
CI Continuous Integration

Comments

@TomNicholas
Copy link
Member

TomNicholas commented Jul 9, 2024 •
edited
Loading

#179 managed to get merged without passing pre-commit's linting checks (linting re-applied in 47303fa). It would be better to run pre-commit on every PR and either loudly fail or automatically push commits to that branch, like xarray does.
@TomNicholas TomNicholas added the CI Continuous Integration label Jul 9, 2024
@norlandrhagen
Copy link
Collaborator

Looks like the pre-commit CI Github app was missing. I added it to the repo.

@norlandrhagen norlandrhagen mentioned this issue Aug 5, 2024
Merged
@norlandrhagen
Copy link
Collaborator

This should now be fixed! This PR shows the .pre-commit CI action working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@norlandrhagen @TomNicholas