Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #3679

Merged
merged 9 commits into from
Jul 25, 2024
Merged

Fix CI #3679

merged 9 commits into from
Jul 25, 2024

Commits on Jul 9, 2024

  1. refactor(yew-macro): ignore dead_code for Lint::lint if not `cfg(… 

    …yew_lints)`

`dead_code` has become more precise in recent toolchains.
    @kawadakk
    kawadakk committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    1ca03b6 View commit details
    Browse the repository at this point in the history

  2. refactor(yew): stop using static mut hack to get static reference t… 

    …o an empty `Vec<VNode>`

The old code triggered `static_mut_refs` lint in the latest stable
toolchain.
    @kawadakk
    kawadakk committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    b90c564 View commit details
    Browse the repository at this point in the history

  3. refactor(yew): ignore clippy::to_string_trait_impl for `impl ToStri… 

    …ng for Classes`
    @kawadakk
    kawadakk committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    0ff4f78 View commit details
    Browse the repository at this point in the history

  4. perf(yew,yew-router): use const {} syntax for thread_local! 

    Addresses `clippy::thread_local_initializer_can_be_made_const`.
May provide performance benefits.
    @kawadakk
    kawadakk committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    f860d9f View commit details
    Browse the repository at this point in the history

  5. refactor(yew): remove `yew::html::component::lifecycle::Stateful::as_… 

    …any_mut`

Addresses `dead_code` lint.
    @kawadakk
    kawadakk committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    0617dd3 View commit details
    Browse the repository at this point in the history

  6. refactor(yew): ignore clippy::incompatible_msrv for `TopologicalQue… 

    …ue::pop_topmost` if Rust version >= 1.66

The use of `BTreeMap::pop_first` (stabilized in 1.66) is already gated by
`#[rustversion(since(1.66))]` hence we can ignore this warning.
    @kawadakk
    kawadakk committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    fb0a203 View commit details
    Browse the repository at this point in the history

  7. refactor(yew): gate `yew::html::component::lifecycle::Stateful::{rend… 

    …ered,props_changed}` by `cfg(feature = "csr")`

Addresses `dead_code` lint.
    @kawadakk
    kawadakk committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    5dbdae2 View commit details
    Browse the repository at this point in the history

  8. test(website-test): ignore clippy::needless_doctest_main

    @kawadakk
    kawadakk committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    cd51a3a View commit details
    Browse the repository at this point in the history

  9. doc(examples): replace clone + assignment with clone_from 

    Addresses `clippy::assigning_clones` lint.
    @kawadakk
    kawadakk committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    640b30a View commit details
    Browse the repository at this point in the history