-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI #3679
base: master
Are you sure you want to change the base?
Fix CI #3679
Conversation
…yew_lints)` `dead_code` has become more precise in recent toolchains.
…o an empty `Vec<VNode>` The old code triggered `static_mut_refs` lint in the latest stable toolchain.
Addresses `clippy::thread_local_initializer_can_be_made_const`. May provide performance benefits.
…any_mut` Addresses `dead_code` lint.
Benchmark - coreYew Master
Pull Request
|
Visit the preview URL for this PR (updated for commit 640b30a): https://yew-rs-api--pr3679-patch-fix-ci-ny64jsqt.web.app (expires Tue, 16 Jul 2024 09:59:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - SSRYew Master
Pull Request
|
Size Comparison
✅ None of the examples has changed their size significantly. |
…ue::pop_topmost` if Rust version >= 1.66 The use of `BTreeMap::pop_first` (stabilized in 1.66) is already gated by `#[rustversion(since(1.66))]` hence we can ignore this warning.
…ered,props_changed}` by `cfg(feature = "csr")` Addresses `dead_code` lint.
Addresses `clippy::assigning_clones` lint.
@kawadakk if you wanna merge this without benchmarks, that is fine by me. The benchmarks CI is failing right now because it cannot find google-chrome (I don't know why; if you want to give a shot at fixing it, feel free to) |
Description
Fixes new rustc and clippy warnings that are generated by the latest Rust toolchain and causing CI failures.
Checklist