Support msteams workflows #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds two helper functions that encapsulate the properties of a successful connector based webhook and a workflow based webhook. Up to now, workflow based webhooks lead to a response where there response code is 202 and the response body is empty. For connector based webhooks, the status code is 200 and the response body is set to "1".
mooikos
reviewed
Dec 6, 2024
as per PR review
- Minor formatting change to simplify 'return response' statement
msd117c
approved these changes
Dec 19, 2024
|
My review worth nothing here 😞 |
|
as I have addressed each point I will go ahead and merge. Since the comments mentioned stylistic topics, these can be changed at any point in time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we got to know the world of Microsoft Teams workflows.
After playing around a bit, I found that this Gem still works successfully when wanting to post a message using Microsoft's adaptive card format.
However, some minor tweaks are required.
With the introduction/replacement/migration of connector based webhooks to workflow based webhooks, both types of responses. This is because workflow based webhook responses have different properties, i.e. status code and body content.
In a previous implementation, we only had to consider the properties of a connector based webhook responses.
these can be found here.
My current understanding is that each response type has the following properties: