Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

202 Response on MsTeamsHermes::Message.deliver returns error despite success #9

Closed
samuelLkennedy opened this issue Sep 10, 2024 · 1 comment

Comments

@samuelLkennedy
Copy link

My first issue on Github!

Connectors are being culled by Microsoft:
https://devblogs.microsoft.com/microsoft365dev/retirement-of-office-365-connectors-within-microsoft-teams/

And they're recommending workflow as an alternative for the future of web hooks in ms teams. See how it's set up here:
https://support.microsoft.com/en-au/office/create-incoming-webhooks-with-workflows-for-microsoft-teams-8ae491c7-0394-4861-ba59-055e33f75498

Which is all good except that MsTeamsHermes::Message.deliver requires a response of '1' to not return an error. A 202 response has an empty body, which is still a valid response and the web hook is working as expected. In the migration from connectors, I think this new success use case needs to be addressed.

Thanks for your contributions!

@huNt-FMJ
Copy link
Collaborator

Addressed in #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants