Fix: invalid cases produce inscrutible failures

wuest · Mar 19, 2024 · 270470a · 270470a
1 parent 3f060ab
commit 270470a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/minitest/proptest/property.rb b/lib/minitest/proptest/property.rb
@@ -106,7 +106,7 @@ def explain
       private
 
       def iterate!
-        while continue_iterate? && @result.nil? && @valid_test_cases <= @max_success / 2
+        while continue_iterate? && @result.nil? && @valid_test_cases <= @max_success
           @valid_test_case = true
           @generated = []
           @generator = ::Minitest::Proptest::Gen.new(@random)

diff --git a/lib/minitest/proptest_plugin.rb b/lib/minitest/proptest_plugin.rb
@@ -77,7 +77,9 @@ def property(&f)
       if prop.status.valid? && !prop.trivial
         Proptest.strike_failure(file, classname, methodname)
       else
-        Proptest.record_failure(file, classname, methodname, prop.result.map(&:value)) unless prop.status.exhausted?
+        unless prop.status.exhausted? || prop.status.invalid?
+          Proptest.record_failure(file, classname, methodname, prop.result.map(&:value))
+        end
 
         raise Minitest::Assertion, prop.explain
       end