Use project configured groupId in generated output artifact names #7095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of hardcoding to use the project name after edu_wpi_first, which broke epilogue publishing This did not affect local maven publishing, since it does not use those specially named and configured artifacts
SamCarlberg
added
the
build
|
Theoretically, this should work. Defintiely make sure the full combine task runs in the PR first. |
ThadHouse
previously approved these changes
Sep 19, 2024
SamCarlberg
force-pushed
the
use-configured-group-id-in-outputs
branch
from
e00d7df
to
2967fa7
Compare
PeterJohnson
approved these changes
Sep 19, 2024
pjreiniger
added a commit
to bzlmodRio/allwpilib
that referenced
this pull request
Sep 21, 2024
* Try to use composite action * Try again * Try with inputs * Again * Whoops * [build] Update vendordeps frcyear to 2025 (wpilibsuite#7087) * [build] Use project configured groupId in generated output artifact names (wpilibsuite#7095) Instead of hardcoding to use the project name after edu_wpi_first, which broke epilogue publishing This did not affect local maven publishing, since it does not use those specially named and configured artifacts * Undo deletion * Redo one delete --------- Co-authored-by: sciencewhiz <[email protected]> Co-authored-by: Sam Carlberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hardcoding to use the project name after
edu_wpi_first_, which broke epilogue publishing. Both projects publish to theedu.wpi.first.epiloguegroup ID, instead of theedu.wpi.first.epilogue-processor/runtimegroup IDs that were computed by the build script.This bug did not affect local maven publishing, since those tasks do not use those specially named and configured artifacts