[wpilib] DCMotorSim cleanup/enhancement #7021
Open
+244
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narmstro2020
changed the title
narmstro2020
changed the title
|
What's the issue here with the failing test? |
|
That test doesn't use the classes you modified, so the 2 inch error in y is due to the randomness injected into the test, not due to your PR. We should hardcode the random seed for testing purposes in a separate PR. |
So nothing I need to do about the test for this PR? |
|
Does anything need to be modified here? |
calcmogul
reviewed
Sep 13, 2024
|
/format |
calcmogul
requested changes
Sep 13, 2024
wpilibj/src/main/java/edu/wpi/first/wpilibj/simulation/DCMotorSim.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Tyler Veness <[email protected]>
…Sim.java Co-authored-by: Tyler Veness <[email protected]>
calcmogul
requested changes
Sep 13, 2024
wpilibj/src/main/java/edu/wpi/first/wpilibj/simulation/FlywheelSim.java
Outdated
Show resolved
Hide resolved
calcmogul
requested changes
Sep 13, 2024
wpilibj/src/main/java/edu/wpi/first/wpilibj/simulation/FlywheelSim.java
Outdated
Show resolved
Hide resolved
wpilibj/src/main/java/edu/wpi/first/wpilibj/simulation/DCMotorSim.java
Outdated
Show resolved
Hide resolved
wpilibj/src/main/java/edu/wpi/first/wpilibj/simulation/DCMotorSim.java
Outdated
Show resolved
Hide resolved
wpilibj/src/main/java/edu/wpi/first/wpilibj/simulation/DCMotorSim.java
Outdated
Show resolved
Hide resolved
|
@calcmogul Are there any more changes to be made on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks DCMotorSim similar to what was done with FlywheelSim in PR #6629