first pass at reviewing the example records for consistency #199
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -146,6 +146,7 @@ | |
| { | ||
| "rel": "items", | ||
| "href": "mqtts://example.org", | ||
| "amComment":"should we add observations to the climate discpline?", | ||
| "channel": "origin/a/wis2/ca-eccc-msc/data/core/climate/observations", | ||
|
There was a problem hiding this comment. I think the channels in our examples should refer to valid topics |
||
| "type": "application/geo+json", | ||
| "title": "Data notifications" | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -143,12 +143,14 @@ | |
| "title": "Open Government Licence - Canada" | ||
| }, | ||
| { | ||
| "amComment1":"technically, the GetCapabilities document is XML", | ||
| "rel": "service", | ||
| "href": "https://geo.weather.gc.ca/geomet-climate?lang=F&service=WMS&request=GetCapabilities", | ||
| "type": "image/png", | ||
|
There was a problem hiding this comment. @tomkralidis change from image/png to text/xml? |
||
| "title": "HYDROMETRIC.STATIONS" | ||
| }, | ||
| { | ||
| "amComment2": "update href with real URL", | ||
| "rel": "items", | ||
|
There was a problem hiding this comment. @tomkralidis replace example.org with real URL |
||
| "href": "mqtts://example.org", | ||
| "channel": "origin/a/wis2/ca-eccc-msc/data/core/hydrology", | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -144,6 +144,7 @@ | |
| "title": "Open Government Licence - Canada" | ||
| }, | ||
| { | ||
| "amComment":"update with real MQTT link", | ||
| "rel": "items", | ||
|
There was a problem hiding this comment. @tomkralidis replace example.org with real MQTT link |
||
| "href": "mqtts://example.org", | ||
| "channel": "origin/a/wis2/ca-eccc-msc/data/core/hydrology", | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -134,12 +134,14 @@ | |||||
| "title": "Open Government Licence - Canada" | ||||||
| }, | ||||||
| { | ||||||
| "amComment": "text/xml? spell out degrees?", | ||||||
| "rel": "service", | ||||||
| "href": "https://geo.weather.gc.ca/geomet?lang=en&service=WMS&request=GetCapabilities&layers=GDPS.ETA_TT", | ||||||
| "type": "image/png", | ||||||
| "title": "Air temperature [\u00b0C]" | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| }, | ||||||
| { | ||||||
| "amComment":"update with real MQTT link", | ||||||
| "rel": "items", | ||||||
| "channel": "origin/a/wis2/ca-eccc-msc/data/core/weather/nwp/global", | ||||||
| "href": "mqtts://example.org", | ||||||
|
There was a problem hiding this comment. @tomkralidis use real MQTT link |
||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| { | ||
| "amComment": "short-range or medium-range? global or limited-area? are all of the discipline topics relevant? Is there a real link for data access?", | ||
|
There was a problem hiding this comment. @Amienshxq I have a couple consistency questions:
|
||
| "id": "urn:wmo:md:cn-cma-babj:data.core.weather.prediction.forecast.short-range.probabilistic.global", | ||
| "type": "Feature", | ||
| "conformsTo": [ | ||
| "http://wis.wmo.int/spec/wcmp/2/conf/core" | ||
|
|
@@ -39,7 +40,7 @@ | |
| "resolution": "P6H" | ||
| }, | ||
| "properties": { | ||
| "title": "CMA Global and Regional Assimilation and Prediction system Global Ensemble Prediction System (GRAPES GEPS) v1.3", | ||
| "description": "GRAPES GEPS is the main technical means to solve the uncertainty of CMA-GFS medium-term forecast and the difficulties of extreme weather forecast.", | ||
| "themes": [ | ||
| { | ||
|
|
@@ -73,16 +74,7 @@ | |
| "title": "Space Weather" | ||
| } | ||
| ], | ||
|
There was a problem hiding this comment. @Amienshxq I removed the concept of broker from this dataset record |
||
| "scheme": "https://codes.wmo.int/wis/topic-hierarchy/earth-system-discipline" | ||
| } | ||
| ], | ||
| "contacts": [ | ||
|
|
@@ -127,7 +119,7 @@ | |
| "language": "en", | ||
| "type": "dataset", | ||
| "created": "2023-04-23T12:00:00Z", | ||
| "updated": "2024-03-13T12:00:00Z", | ||
| "keywords": [ | ||
| "WIS2", | ||
| "forecast", | ||
|
|
@@ -144,7 +136,7 @@ | |
| }, | ||
| { | ||
| "rel": "items", | ||
| "channel": "origin/a/wis2/cn-cma-babj/weather/prediction/forecast/shortrange/probabilistic/global", | ||
| "type": "application/geo+json", | ||
| "title": "Data notifications - WMO WIS Global Broker - CMA", | ||
| "href": "mqtts://everyone:[email protected]:8883" | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -98,20 +98,20 @@ | |
| "keywords": [ | ||
| "WIS2", | ||
| "surface", | ||
| "observations" | ||
| ] | ||
| }, | ||
| "links": [ | ||
| { | ||
| "amComment":"is there a non-dev URL?", | ||
| "rel": "data", | ||
| "type": "text/html", | ||
| "title": "Raw data download (bufr4)", | ||
| "href": "https://wisdev.kishou.go.jp/data/wis2/chn/babj/data/core/weather/surface-based-observations/synop/" | ||
|
There was a problem hiding this comment. data is not accessible by this URL |
||
| }, | ||
| { | ||
| "rel": "items", | ||
| "channel": "origin/a/wis2/cn-cma/data/core/weather/surface-based-observations/synop", | ||
| "type": "application/geo+json", | ||
| "title": "Data notifications - WMO WIS Global Broker - CMA", | ||
| "href": "mqtts://everyone:[email protected]:8883" | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,6 +49,7 @@ | |
| "title": "dataset is in 24/7 operation", | ||
| "url": "https://vocab.met.no/mmd/en/page/Operational_Status" | ||
| }, | ||
| "amComment1":"move these keywords into concepts", | ||
| "keywords": [ | ||
| "atmosphere", | ||
| "land", | ||
|
|
@@ -127,6 +128,7 @@ | |
| "scheme": "https://wis.wmo.int/2012/codelists/WMOCodeLists.xml#WMO_CategoryCode#MD_KeywordTypeCode_dataCentre" | ||
| } | ||
| ], | ||
| "amComment2":"move formats under links.distribution.availableFormats", | ||
| "formats": [ | ||
| "application/x-eum-hrit" | ||
| ], | ||
|
|
@@ -143,6 +145,7 @@ | |
| { | ||
| "rel": "items", | ||
| "channel": "origin/a/wis2/int-eumetsat/data/core/weather/space-based-observations/satellite4nowcasting/Meteosat-10/ImageL1-5", | ||
| "amComment":"update channel when satellite topics are defined, change href", | ||
| "href": "mqtts://example.org", | ||
| "type": "application/geo+json", | ||
| "title": "Data notifications" | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,12 +39,14 @@ | |
| }, | ||
| "properties": { | ||
| "created": "2022-06-23T18:36:00Z", | ||
| "updated": "2024-03-13T12:00:00Z", | ||
| "wmo:dataPolicy": "core", | ||
| "rights": "access", | ||
|
There was a problem hiding this comment. @solson-nws what does "access" mean? |
||
| "amComment1":"what does access mean?", | ||
| "type": "dataset", | ||
| "title": "Global Forecast System 1 Degree Resolution", | ||
| "description": "The Global Forecast System is a weather forecast model produced by the National Centers for Environmental Prediction.", | ||
| "amComment2":"can the description be expanded on a little bit?", | ||
| "keywords": [ | ||
| "Geopotential Height", | ||
| "Planetary Boundary Layer Height", | ||
|
|
@@ -212,56 +214,70 @@ | |
| { | ||
| "concepts": [ | ||
| { | ||
| "id": "weather", | ||
| "title": "Weather" | ||
| } | ||
| ], | ||
| "scheme": "http:codes.wmo.int/wis/topic-hierarchy/earth-system-discipline/weather" | ||
| }, | ||
| { "amComment3":"remove because it doesn't have a definition and I don't like using old ISO codes", | ||
| "concepts": [ | ||
| { | ||
| "id": "meteorology", | ||
| "title": "meteorology" | ||
| } | ||
| ], | ||
| "scheme": "http://wis.wmo.int/2012/codelists/WMOCodeLists#WMO_CategoryCode" | ||
| }, | ||
|
|
||
| { | ||
| "concepts": [ | ||
| { | ||
| "title": "Absolute vorticity", | ||
| "id": "0-2-10" | ||
| }, | ||
| { | ||
| "title": "Albedo", | ||
| "id":"0-19-1" | ||
| }, | ||
| { | ||
| "title": "Pressure reduced to MSL", | ||
| "id":"0-3-1" | ||
| }, | ||
| { | ||
| "title": "Snow cover", | ||
| "id":"0-1-42" | ||
| }, | ||
| { | ||
| "title": "Snow depth", | ||
| "id":"0-1-11" | ||
| }, | ||
| { | ||
| "title": "Soil temperature", | ||
| "id":"2-3-18" | ||
| }, | ||
| { | ||
| "title": "v-component of wind", | ||
| "id":"0-2-3" | ||
| }, | ||
| { | ||
| "title": "v-component storm motion", | ||
| "id":"0-2-28" | ||
| }, | ||
| { | ||
| "title": "Vegetation", | ||
| "id":"2-0-4" | ||
| }, | ||
| { | ||
| "title":"Vertical velocity (geometric))", | ||
| "id":"0-2-9" | ||
| }, | ||
| { | ||
| "title":"Vertical velocity (pressure)", | ||
| "id":"0-2-8" | ||
| } | ||
| ], | ||
| "scheme": "https://codes.wmo.int/grib2/codeflag/4.2" | ||
| } | ||
| ], | ||
| "contacts": [ | ||
|
|
@@ -308,8 +324,16 @@ | |
| { | ||
| "rel": "data", | ||
| "href": "https://nomads.ncep.noaa.gov/pub/data/nccf/com/gfs/prod/", | ||
| "type": "application/grib;edition=2", | ||
| "title": "NOAA Operational Model Archive and Distribution System (NOMADS)" | ||
| }, | ||
| { | ||
| "amComment":"need to update channel", | ||
| "rel": "items", | ||
| "channel": ".../weather/prediction/forecast/.../global", | ||
| "type": "application/geo+json", | ||
| "title": "Data notifications", | ||
| "href": "mqtts://everyone:[email protected]:8883" | ||
| } | ||
| ] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,12 +38,12 @@ | |
| ] | ||
| }, | ||
| "properties": { | ||
| "created": "2022-08-01T12:00:00Z", | ||
| "updated": "2024-03-13T12:00:00Z", | ||
| "wmo:dataPolicy": "core", | ||
| "type": "dataset", | ||
| "title": "Goes 16 Advanced Baseline Imager Level 2 Sea Surface Temperature", | ||
| "description": "Sea Surface Temperature for each cloud-free pixel over water. The Sea Surface Temperature algorithm employed on GOES 18 [16 or 18?] will use hybrid physical-regression retrieval in order to produce a more accurate product.", | ||
| "keywords": [ | ||
| "Sea Surface Temperature", | ||
| "Geostationary Operational Environmental Satellite 16 (GOES-16)", | ||
|
|
@@ -65,7 +65,6 @@ | |
| "Atmosphere", | ||
| "meteorology" | ||
| ], | ||
| "language": "en", | ||
| "themes": [ | ||
| { | ||
|
|
@@ -74,9 +73,39 @@ | |
| "id": "weather", | ||
| "title": "Weather", | ||
| "url": "https://codes.wmo.int/wis/topic-hierarchy/earth-system-discipline/weather" | ||
| }, | ||
| { | ||
| "id": "climate", | ||
| "title": "Climate", | ||
| "url": "https://codes.wmo.int/wis/topic-hierarchy/earth-system-discipline/climate" | ||
| }, | ||
| { | ||
| "id": "ocean", | ||
| "title": "Ocean", | ||
| "url": "https://codes.wmo.int/wis/topic-hierarchy/earth-system-discipline/ocean" | ||
| } | ||
| ], | ||
| "scheme": "https://codes.wmo.int/wis/topic-hierarchy/earth-system-discipline" | ||
| }, | ||
| { | ||
| "concepts": [ | ||
| { | ||
| "id": "seaSurfaceTemperature", | ||
| "title": "Sea surface temperature", | ||
| "url": "http://codes.wmo.int/common/quantity-kind/seaSurfaceTemperature" | ||
| } | ||
| ], | ||
| "scheme": "http://codes.wmo.int/common/quantity-kind" | ||
| }, | ||
| { | ||
| "concepts": [ | ||
| { | ||
| "id": "95", | ||
| "title": "Sea surface temperature", | ||
| "url": "http://codes.wmo.int/wmdr/ObservedVariableOcean/95" | ||
| } | ||
| ], | ||
| "scheme": "https://codes.wmo.int/wmdr/ObservedVariableOcean" | ||
| } | ||
| ], | ||
| "contacts": [ | ||
|
|
@@ -117,11 +146,13 @@ | |
| ] | ||
| } | ||
| ], | ||
| "amReview": [ | ||
| "formats property is not part of the wcmp2, move to all links with distribution.availableFormats.name?" | ||
| ], | ||
| "formats": [ | ||
| "NetCDF" | ||
| ], | ||
| "rights": "There are no restrictions on the use of this data." | ||
| }, | ||
| "links": [ | ||
| { | ||
|
|
@@ -132,13 +163,7 @@ | |
| }, | ||
| { | ||
| "rel": "data", | ||
| "href": "https://console.cloud.google.com/storage/browser/gcp-public-data-goes-16/ABI-L2-SSTF", | ||
| "type": "text/html", | ||
| "title": "Google Cloud GOES-16 L2 Sea Surface Temperature" | ||
| }, | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomkralidis is there a real URL to use instead?