first pass at reviewing the example records for consistency #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
amilan17
commented
Mar 21, 2024
| @@ -133,6 +133,7 @@ | |||
| }, | |||
| "links": [ | |||
| { | |||
| "amComment":"is there a real URL now?", | |||
There was a problem hiding this comment.
@tomkralidis is there a real URL to use instead?
amilan17
commented
Mar 21, 2024
| @@ -146,6 +146,7 @@ | |||
| { | |||
| "rel": "items", | |||
| "href": "mqtts://example.org", | |||
| "amComment":"should we add observations to the climate discpline?", | |||
| "channel": "origin/a/wis2/ca-eccc-msc/data/core/climate/observations", | |||
There was a problem hiding this comment.
I think the channels in our examples should refer to valid topics
@tomkralidis
amilan17
commented
Mar 21, 2024
| @@ -143,12 +143,14 @@ | |||
| "title": "Open Government Licence - Canada" | |||
| }, | |||
| { | |||
| "amComment1":"technically, the GetCapabilities document is XML", | |||
| "rel": "service", | |||
| "href": "https://geo.weather.gc.ca/geomet-climate?lang=F&service=WMS&request=GetCapabilities", | |||
| "type": "image/png", | |||
There was a problem hiding this comment.
@tomkralidis change from image/png to text/xml?
amilan17
commented
Mar 21, 2024
| "rel": "service", | ||
| "href": "https://geo.weather.gc.ca/geomet-climate?lang=F&service=WMS&request=GetCapabilities", | ||
| "type": "image/png", | ||
| "title": "HYDROMETRIC.STATIONS" | ||
| }, | ||
| { | ||
| "amComment2": "update href with real URL", | ||
| "rel": "items", |
There was a problem hiding this comment.
@tomkralidis replace example.org with real URL
amilan17
commented
Mar 21, 2024
| @@ -144,6 +144,7 @@ | |||
| "title": "Open Government Licence - Canada" | |||
| }, | |||
| { | |||
| "amComment":"update with real MQTT link", | |||
| "rel": "items", | |||
There was a problem hiding this comment.
@tomkralidis replace example.org with real MQTT link
amilan17
commented
Mar 21, 2024
| @@ -134,12 +134,14 @@ | |||
| "title": "Open Government Licence - Canada" | |||
| }, | |||
| { | |||
| "amComment": "text/xml? spell out degrees?", | |||
| "rel": "service", | |||
| "href": "https://geo.weather.gc.ca/geomet?lang=en&service=WMS&request=GetCapabilities&layers=GDPS.ETA_TT", | |||
| "type": "image/png", | |||
| "title": "Air temperature [\u00b0C]" | |||
There was a problem hiding this comment.
Suggested change
| "title": "Air temperature [\u00b0C]" | |
| "title": "Air temperature [degrees]" |
amilan17
commented
Mar 21, 2024
| "rel": "service", | ||
| "href": "https://geo.weather.gc.ca/geomet?lang=en&service=WMS&request=GetCapabilities&layers=GDPS.ETA_TT", | ||
| "type": "image/png", | ||
| "title": "Air temperature [\u00b0C]" | ||
| }, | ||
| { | ||
| "amComment":"update with real MQTT link", | ||
| "rel": "items", | ||
| "channel": "origin/a/wis2/ca-eccc-msc/data/core/weather/nwp/global", | ||
| "href": "mqtts://example.org", |
There was a problem hiding this comment.
@tomkralidis use real MQTT link
amilan17
commented
Mar 21, 2024
| @@ -126,6 +126,7 @@ | |||
| }, | |||
| "links": [ | |||
| { | |||
| "amComment":"this URL redirects to the GetCapabilities doc", | |||
There was a problem hiding this comment.
Suggested change
| "amComment":"this URL redirects to the GetCapabilities doc", |
amilan17
commented
Mar 21, 2024
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "id": "urn:wmo:md:cn-cma-babj:data.core.weather.prediction.forecast.shortrange.probabilistic.global", | |||
| "amComment": "short-range or medium-range? global or limited-area? are all of the discipline topics relevant? Is there a real link for data access?", | |||
There was a problem hiding this comment.
@Amienshxq I have a couple consistency questions:
- short-range or medium-range?
- global or limited-area?
- are all of the discipline topics relevant?
- Is there a real link for data access?"
amilan17
commented
Mar 21, 2024
| "scheme": "https://github.com/wmo-im/wis2-topic-hierarchy/blob/main/topic-hierarchy/earth-system-discipline/index.csv" | ||
| }, | ||
| { | ||
| "concepts": [ |
There was a problem hiding this comment.
@Amienshxq I removed the concept of broker from this dataset record
amilan17
commented
Mar 21, 2024
| ] | ||
| }, | ||
| "links": [ | ||
| { | ||
| "amComment":"is there a non-dev URL?", | ||
| "rel": "data", | ||
| "type": "text/html", | ||
| "title": "Raw data download (bufr4)", | ||
| "href": "https://wisdev.kishou.go.jp/data/wis2/chn/babj/data/core/weather/surface-based-observations/synop/" |
There was a problem hiding this comment.
data is not accessible by this URL
amilan17
commented
Mar 21, 2024
| @@ -39,12 +39,14 @@ | |||
| }, | |||
| "properties": { | |||
| "created": "2022-06-23T18:36:00Z", | |||
| "updated": "2022-06-23T18:36:00Z", | |||
| "updated": "2024-03-13T12:00:00Z", | |||
| "wmo:dataPolicy": "core", | |||
| "rights": "access", | |||
There was a problem hiding this comment.
@solson-nws what does "access" mean?
Closed
Merged
|
Superceded by #201 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#198