Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Cleaning repository from not needed code #2

Merged
merged 7 commits into from
May 15, 2020

Conversation

kalwalt
Copy link
Member

@kalwalt kalwalt commented May 15, 2020

Starting from this issue #1 I will remove the code that we don't need and can't be used with emscripten or other transpilers.

  • restored ARMulti and other files needed for jsartoolkit5 and artoolkit5-js compilation

@kalwalt kalwalt added the enhancement New feature or request label May 15, 2020
@kalwalt kalwalt self-assigned this May 15, 2020
@kalwalt
Copy link
Member Author

kalwalt commented May 15, 2020

I think i will remove also Eden, it use a lot internally GL and depends on other libs that to be transpiled with Emscripten is not so simple. It has internally glm.c but even this rely heavily on OpenGL, so i think it's useless.
Note: ArtoolkitX also has no Eden in the Source anymore.

@kalwalt
Copy link
Member Author

kalwalt commented May 15, 2020

I'm not sure if i will remove also all makefiles, or leave them and maybe modify them for a hypothetical use.

@kalwalt kalwalt mentioned this pull request May 15, 2020
7 tasks
@kalwalt kalwalt changed the base branch from master to dev May 15, 2020 14:16
@kalwalt
Copy link
Member Author

kalwalt commented May 15, 2020

I have tested this code with jsartoolkit5 and artoolkit5-js and it can be compiled. I will see for makefiles. I'm merging this.

@kalwalt kalwalt merged commit d9504bf into dev May 15, 2020
@kalwalt kalwalt mentioned this pull request May 15, 2020
@kalwalt kalwalt deleted the feature-cleaning-repository branch November 20, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant