Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code #1

Open
3 of 7 tasks
kalwalt opened this issue May 13, 2020 · 5 comments
Open
3 of 7 tasks

Remove dead code #1

kalwalt opened this issue May 13, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@kalwalt
Copy link
Member

kalwalt commented May 13, 2020

I removed most of the code that we don't need, but i think there are some files that we can delete too, I will create a list here of which files that we need to remove, but that needs to be tested.

inside include folder:

  • AR folder:

    • arosg.h
    • gsub.h, gsubConfig.h, gsub_es.h. gsub_es2.h, gsub_lite.h
    • video.h, videoConfig.h, VideoLuma.h, VideoRGBA.h
  • ARUtil folder:

    • android.h
    • thread_sub.h
  • ARWrapper folder:
    i left this but not sure what to do with this.

  • Eden folder:
    does we need this?

  • glStateCache.h and glStateCache2.h

inside lib/SRC folder:

  • AR folder:

    • ref. files to Pattern Marker? what other?
  • ARUtil folder:
    as for the include folder files tat refer to android and threading

to be completed...

@kalwalt kalwalt added the enhancement New feature or request label May 13, 2020
@kalwalt kalwalt self-assigned this May 13, 2020
@kalwalt
Copy link
Member Author

kalwalt commented May 13, 2020

We can also remove all the Makefiles, if we think that we will not build the libs with the makefile system.
There is another question I ask myself: if webarkitLib will be used also by jsartoolkit5 I cannot go to remove certain files concerning Pattern, Barcode or Mult Markers, in this case I have to see how much to go deep in cleaning.

@ThorstenBux
Copy link
Member

ThorstenBux commented May 13, 2020 via email

@kalwalt
Copy link
Member Author

kalwalt commented May 15, 2020

Eden has been removed with this commit 0ec0048 see also #2 (comment)

@subjectdenied
Copy link

wouldn't it be better to integrate (work on the build-system of the original artoolkit) webarkit/jsartoolkit/ into artoolkit and allow artoolkit to be built for "web", instead of forking in a way merging the "web" artoolkit with the "desktop" artoolkit will be amost impossible in the future?

@kalwalt
Copy link
Member Author

kalwalt commented May 17, 2020

@subjectdenied we want to develop a new lib that is based in part on the original Artoolkit5 - ArtoolkitX and oter features. Consider that actually the ARtoolkit5 repository is more than 500 mb but the code required to buld jsartoolkit5 it's around 8mb. Does make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants