feat: protobuf-es #1245
Closed
feat: protobuf-es #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
danisharora099
force-pushed
the
feat/protobuf-es
branch
from
ee33ec8 to
b3e5e41
Compare
danisharora099
force-pushed
the
feat/protobuf-es
branch
from
b3e5e41 to
02d44a5
Compare
fryorcraken
reviewed
Mar 16, 2023
packages/interfaces/src/message.ts
Outdated
| @@ -32,7 +20,7 @@ export interface IMessage { | |||
| } | |||
|
|
|||
| export interface IMetaSetter { | |||
| (message: IProtoMessage & { meta: undefined }): Uint8Array; | |||
| (message: proto_message.WakuMessage & { meta: undefined }): Uint8Array; | |||
There was a problem hiding this comment.
maybe have a type IProtoMessage = proto_message.WakuMessage and re-export it. Less changes across the code base and fair to make the type easier to access
fryorcraken
reviewed
Mar 16, 2023
| @@ -42,7 +37,7 @@ export type StoreQueryOptions = { | |||
| * Cursor as an index to start a query from. Must be generated from a Waku | |||
| * Message. | |||
| */ | |||
| cursor?: Cursor; | |||
| cursor?: proto_store.Index; | |||
There was a problem hiding this comment.
I don't think we should expose proto class to the user. We should keep the Cursor interface.
fryorcraken
reviewed
Mar 16, 2023
| @@ -1,4 +1,4 @@ | |||
| import { IProtoMessage } from "@waku/interfaces"; | |||
| import { proto_message } from "@waku/proto"; | |||
There was a problem hiding this comment.
Good reason to re-export proto_message.WakuMessage from @waku/interfaces as IProtoMessage.
fryorcraken
reviewed
Mar 16, 2023
Comment on lines
+38
to
+42
| rateLimitProof: undefined, | ||
| timestamp: undefined, | ||
| meta: undefined, | ||
| version: undefined, | ||
| ephemeral: undefined, |
Comment on lines
+49
to
+51
| "@bufbuild/buf": "^1.15.0-1", | ||
| "@bufbuild/protobuf": "^1.1.1", | ||
| "@bufbuild/protoc-gen-es": "^1.1.1" |
There was a problem hiding this comment.
I assumed two of these deps are devDependencies, no?
packages/peer-exchange/package.json
Outdated
| @@ -53,6 +53,7 @@ | |||
| "@libp2p/interface-peer-discovery": "^1.0.5", | |||
| "@libp2p/interfaces": "^3.3.1", | |||
| "@waku/enr": "*", | |||
| "@waku/interfaces": "*", | |||
There was a problem hiding this comment.
Why? it should only contain types and hence remain a devDepedencies item
packages/peer-exchange/src/rpc.ts
Outdated
| @@ -1,3 +1,4 @@ | |||
| import { PeerExchangeQueryParams } from "@waku/interfaces"; | |||
There was a problem hiding this comment.
Suggested change
| import { PeerExchangeQueryParams } from "@waku/interfaces"; | |
| import type { PeerExchangeQueryParams } from "@waku/interfaces"; |
Boom, 13% size increase |
danisharora099
force-pushed
the
feat/protobuf-es
branch
from
2473da8 to
ddcf16b
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#335