Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES-1393 Fix /readyz returning 503 if readinessProbes not defined in options #7361

Merged

Conversation

sethidden
Copy link
Contributor

@sethidden sethidden commented Dec 16, 2024

ES-1393

This wouldn't happen if the package had null checks enabled

@sethidden sethidden requested a review from a team as a code owner December 16, 2024 12:23
@sethidden sethidden force-pushed the ES-1393-middleware-readycheck-fails-empty-readinesschecks branch from 42e2082 to 67ba895 Compare December 16, 2024 12:24
Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: b7943fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vue-storefront/middleware Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sethidden sethidden force-pushed the ES-1393-middleware-readycheck-fails-empty-readinesschecks branch from 67ba895 to b7943fb Compare December 16, 2024 12:25
Copy link

sonarcloud bot commented Dec 16, 2024

@sethidden sethidden merged commit 591ba61 into main Dec 16, 2024
3 checks passed
@sethidden sethidden deleted the ES-1393-middleware-readycheck-fails-empty-readinesschecks branch December 16, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants