ES-1393 Fix /readyz returning 503 if readinessProbes not defined in o…

…ptions
vuestorefront · Dec 16, 2024 · 67ba895 · 67ba895
1 parent f9fab52
commit 67ba895
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/.changeset/curly-gifts-hang.md b/.changeset/curly-gifts-hang.md
@@ -0,0 +1,7 @@
+---
+"@vue-storefront/middleware": patch
+---
+
+- **[FIXED]** Fix /readyz returning 503 if readinessProbes not passed in middleware.config.ts
+
+Before this fix, sending a GET request would return { "status": "error" } and a HTTP 503 status. This happened only when `readinessProbes` wasn't added to middleware options (the default behavior)
diff --git a/packages/middleware/src/terminus.ts b/packages/middleware/src/terminus.ts
@@ -30,7 +30,7 @@ export const createReadyzHandler =
   };
 
 export const createTerminusOptions = (
-  readinessChecks: ReadinessProbe[]
+  readinessChecks: ReadinessProbe[] = []
 ): TerminusOptions => {
   return {
     useExit0: true,