Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-8819: Finish FTDC #4579

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+102 −33
Open

RSDK-8819: Finish FTDC #4579

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a65d835
RSDK-8819: Add goutils rpc stats to FTDC.
dgottlieb Nov 21, 2024
6a945bf
RSDK-8819: Parameterize FTDC diagnostics.data directory.
dgottlieb Nov 21, 2024
8ca673d
RSDK-8819: Sort charts in ftdc viewing by metric name.
dgottlieb Nov 21, 2024
68a11a6
RSDK-8819: Turn on FTDC by default.
dgottlieb Nov 21, 2024
61ef64a
lint
dgottlieb Nov 21, 2024
906a3b7
lint
dgottlieb Nov 21, 2024
fe547ab
lint
dgottlieb Nov 21, 2024
9b1ce55
lint
dgottlieb Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion robot/impl/local_robot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,8 +416,12 @@ func newWithResources(

var ftdcWorker *ftdc.FTDC
if rOpts.enableFTDC {
partID := "local-config"
if cfg.Cloud != nil {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug fix

partID = cfg.Cloud.ID
}
// CloudID is also known as the robot part id.
ftdcWorker = ftdc.New(ftdc.DefaultDirectory(config.ViamDotDir, cfg.Cloud.ID), logger.Sublogger("ftdc"))
ftdcWorker = ftdc.New(ftdc.DefaultDirectory(config.ViamDotDir, partID), logger.Sublogger("ftdc"))
ftdcWorker.Start()
}

Expand Down
2 changes: 1 addition & 1 deletion web/server/entrypoint.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ type Arguments struct {
OutputTelemetry bool `flag:"output-telemetry,usage=print out telemetry data (metrics and spans)"`
DisableMulticastDNS bool `flag:"disable-mdns,usage=disable server discovery through multicast DNS"`
DumpResourcesPath string `flag:"dump-resources,usage=dump all resource registrations as json to the provided file path"`
EnableFTDC bool `flag:"ftdc,usage=enable fulltime data capture for diagnostics [beta feature]"`
EnableFTDC bool `flag:"ftdc,default=true,usage=enable fulltime data capture for diagnostics"`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stole from WebRTC above on line 45. Hand tested that -ftdc=false turns this off.

}

type robotServer struct {
Expand Down
Loading