RSDK-8819: Finish FTDC #4579
Open
RSDK-8819: Finish FTDC #4579
+102
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
dgottlieb
commented
Nov 21, 2024
| // `ftdcDirectory`. | ||
| func New(ftdcDirectory string, logger logging.Logger) *FTDC { | ||
| ret := newFTDC(logger) | ||
| ret.maxFileSizeBytes = 1_000_000 |
There was a problem hiding this comment.
Made the settings a more formal division. One either passes in a directory and all these variables about managing files are initialized. Or one passes in a writer and none of those variables matter.
| @@ -536,7 +553,7 @@ func (ftdc *FTDC) checkAndDeleteOldFiles() error { | |||
| // deletion testing. Filename generation uses padding such that we can rely on there before 2/4 | |||
| // digits for every numeric value. | |||
| // | |||
| //nolint | |||
| // nolint | |||
There was a problem hiding this comment.
It joys me that our linter lints our linter
| ftdc.ftdcDir = ftdcFileDir | ||
| // We must not use `NewWithWriter`. Forcing a writer for FTDC data is not compatible with FTDC | ||
| // file rotation. | ||
| ftdc := New(ftdcFileDir, logger.Sublogger("ftdc")) |
There was a problem hiding this comment.
The "refactor" of New vs NewWithWriter resulted in changing the order here. First create the directory, then pass it to the constructor.
robot/impl/local_robot.go
Outdated
| @@ -416,7 +416,8 @@ func newWithResources( | |||
|
|
|||
| var ftdcWorker *ftdc.FTDC | |||
| if rOpts.enableFTDC { | |||
| ftdcWorker = ftdc.New(logger.Sublogger("ftdc")) | |||
| // CloudID is also known as the robot part id. | |||
| ftdcWorker = ftdc.New(ftdc.DefaultDirectory(config.ViamDotDir, cfg.Cloud.ID), logger.Sublogger("ftdc")) | |||
There was a problem hiding this comment.
Technically has a bug -- cfg.Cloud.ID is nil for local configs. Fixed in last commit.
ftdc/cmd/parser.go
Outdated
| @@ -36,6 +39,31 @@ type gnuplotWriter struct { | |||
| options graphOptions | |||
| } | |||
|
|
|||
| type KVPair[K, V any] struct { | |||
There was a problem hiding this comment.
I expect you'll enjoy this @benjirewis
ftdc/cmd/parser.go
Outdated
| nolintPrintln("Expected an FTDC filename. E.g: go run parser.go <path-to>/viam-server.ftdc") | ||
| return | ||
| } | ||
|
|
||
| data, err := ftdc.Parse(ftdcFile) | ||
| logger := logging.NewDebugLogger("parser") | ||
| logger.SetLevel(logging.WARN) |
There was a problem hiding this comment.
Replaced with a simple NewLogger and removed the SetLevel -- using the INFO default.
| @@ -416,8 +416,12 @@ func newWithResources( | |||
|
|
|||
| var ftdcWorker *ftdc.FTDC | |||
| if rOpts.enableFTDC { | |||
| partID := "local-config" | |||
| if cfg.Cloud != nil { | |||
| @@ -48,7 +48,7 @@ type Arguments struct { | |||
| OutputTelemetry bool `flag:"output-telemetry,usage=print out telemetry data (metrics and spans)"` | |||
| DisableMulticastDNS bool `flag:"disable-mdns,usage=disable server discovery through multicast DNS"` | |||
| DumpResourcesPath string `flag:"dump-resources,usage=dump all resource registrations as json to the provided file path"` | |||
| EnableFTDC bool `flag:"ftdc,usage=enable fulltime data capture for diagnostics [beta feature]"` | |||
| EnableFTDC bool `flag:"ftdc,default=true,usage=enable fulltime data capture for diagnostics"` | |||
There was a problem hiding this comment.
Stole from WebRTC above on line 45. Hand tested that -ftdc=false turns this off.
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.