APP-6785: Remove local control page - remove web workflows #4523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
ethanlookpotts
requested review from
abe-winter,
Otterverse and
zaporter-work
ethanlookpotts
commented
Nov 4, 2024
ethanlookpotts
added
appimage
abe-winter
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Seems like there are a few other npm-publish.yml references:
I think this will cause the workflows on main to fail.
➜ workflows git:(APP-6785/ethanlookpotts/remove-web-workflows) ✗ rg "npm"
main.yml
63: npm_publish:
64: uses: viamrobotics/rdk/.github/workflows/npm-publish.yml@main
stable.yml
63: npm_publish:
64: uses: viamrobotics/rdk/.github/workflows/npm-publish.yml@main
releasecandidate.yml
46: npm_publish:
47: uses: viamrobotics/rdk/.github/workflows/npm-publish.yml@main
|
@zaporter-work great catch |
zaporter-work
approved these changes
Nov 4, 2024
|
Ah - didn't realize that James was OOO today - will wait to merge until tomorrow so he has a chance to review. |
Otterverse
approved these changes
Nov 5, 2024
|
Holding on this PR until we resolve the discussion about agent healthchecks. |
|
I was able to verify that #4520 works as expected, so I'm going to go ahead and merge this and put the next PR up for review. Please holler if you notice anything with workflows! |
ethanlookpotts
deleted the
APP-6785/ethanlookpotts/remove-web-workflows
branch
hexbabe
pushed a commit
to hexbabe/sean-rdk
that referenced
this pull request
Nov 14, 2024
hexbabe
pushed a commit
to hexbabe/sean-rdk
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are removing RC from the RDK - users are now expected to use app.viam.com to control their machine.
This PR just removes the workflows and anything web related from
.github, which makes it easier to remove the code in the next step. (There is risk that there will be drift & issues inweb/frontenduntil the latter is submitted, but we don't expect any changes there because we're removing it.)Review requests
.github- did I miss anything related to the web app?