Skip to content

Commit

Permalink
APP-6785: Remove local control page - remove web workflows (#4523)
Browse files Browse the repository at this point in the history
  • Loading branch information
ethanlookpotts authored Nov 7, 2024
1 parent 13092f8 commit 3af2e89
Show file tree
Hide file tree
Showing 9 changed files with 1 addition and 163 deletions.
13 changes: 0 additions & 13 deletions .github/CODEOWNERS

This file was deleted.

11 changes: 0 additions & 11 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,6 @@ updates:
assignees: #TODO: make list
- stevebriskin
- mcvella
- package-ecosystem: "npm"
directory: "web/frontend"
schedule:
interval: "daily"
allow:
- dependency-type: "all"
ignore:
- dependency-name: "proto" # generated proto files
- dependency-name: "*"
update-types: ["version-update:semver-major", "version-update:semver-minor", "version-update:semver-patch"]
open-pull-requests-limit: 0
- package-ecosystem: "github-actions"
directory: "/"
schedule:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/full-static.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ jobs:
with:
go-version-file: go.mod

- name: build js
run: make build-web
- name: build go
shell: bash
run: |
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,6 @@ jobs:
secrets:
GCP_CREDENTIALS: ${{ secrets.GCP_CREDENTIALS }}

npm_publish:
uses: viamrobotics/rdk/.github/workflows/npm-publish.yml@main
needs: test
secrets:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

license_finder:
uses: viamrobotics/rdk/.github/workflows/license_finder.yml@main

Expand Down
49 changes: 0 additions & 49 deletions .github/workflows/npm-bump-version.yml

This file was deleted.

33 changes: 0 additions & 33 deletions .github/workflows/npm-publish.yml

This file was deleted.

6 changes: 0 additions & 6 deletions .github/workflows/releasecandidate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,6 @@ jobs:
secrets:
GCP_CREDENTIALS: ${{ secrets.GCP_CREDENTIALS }}

npm_publish:
uses: viamrobotics/rdk/.github/workflows/npm-publish.yml@main
needs: test
secrets:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

slack-workflow-status:
if: ${{ failure() }}
name: Post Workflow Status To Slack
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/stable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,6 @@ jobs:
secrets:
GCP_CREDENTIALS: ${{ secrets.GCP_CREDENTIALS }}

npm_publish:
uses: viamrobotics/rdk/.github/workflows/npm-publish.yml@main
needs: test
secrets:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

slack-workflow-status:
if: ${{ failure() }}
name: Post Workflow Status To Slack
Expand Down
38 changes: 1 addition & 37 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -202,55 +202,19 @@ jobs:
pip install -r cli/test-requirements.txt
check-jsonschema --schemafile ./cli/module.schema.json meta2.json
test_web_e2e:
name: Test End-to-End and Web
runs-on: ubuntu-latest
container: ghcr.io/viamrobotics/rdk-devenv:amd64-cache
timeout-minutes: 15
steps:
- uses: actions/checkout@v3
with:
ref: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.head.sha || github.ref }}

- name: Chown
run: chown -R testbot:testbot .

- name: Verify no uncommitted changes from "make build-web lint-web"
run: |
sudo -Hu testbot bash -lc 'git init && git add . && make build-web lint-web'
GEN_DIFF=$(git status -s)
if [ -n "$GEN_DIFF" ]; then
echo '"make build-web lint-web" resulted in changes not in git' 1>&2
git status
exit 1
fi
- name: Install dependencies
run: |
apt-get update && apt-get -qy install libgtk2.0-0 libgtk-3-0 libgbm-dev libnotify-dev libgconf-2-4 libnss3 libxss1 libasound2 libxtst6 xauth xvfb netcat-openbsd lsof
- name: Run web tests
run: sudo -Hu testbot bash -lc 'make test-web'

- name: Run e2e tests
run: sudo -Hu testbot bash -lc 'make test-e2e E2E_ARGS="-k"'

test_passing:
name: All Tests Passing
needs: [test_go, test_web_e2e, test32, motion_tests]
needs: [test_go, test32, motion_tests]
runs-on: [ubuntu-latest]
if: always()
steps:
- name: Check Results
run: |
echo Go Unit Tests: ${{ needs.test_go.result }}
echo Go 32-bit Tests: ${{ needs.test32.result }}
echo Web/E2E Tests: ${{ needs.test_web_e2e.result }}
echo Motion Tests: ${{ needs.motion_tests.result }}
[ "${{ needs.test_go.result }}" == "success" ] && \
[ "${{ needs.test32.result }}" == "success" ] && \
[ "${{ needs.test_web_e2e.result }}" == "success" ] && \
[ "${{ needs.motion_tests.result }}" == "success" ]
# Now that RDK is public, can't directly comment without token having full read/write access
Expand Down

0 comments on commit 3af2e89

Please sign in to comment.